[前][次][番号順一覧][スレッド一覧]

ruby-changes:20708

From: suke <ko1@a...>
Date: Sat, 30 Jul 2011 17:38:12 +0900 (JST)
Subject: [ruby-changes:20708] suke:r32756 (trunk): * test/win32ole/test_win32ole_variant.rb: use skip method to skip the test.

suke	2011-07-30 17:36:47 +0900 (Sat, 30 Jul 2011)

  New Revision: 32756

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=32756

  Log:
    * test/win32ole/test_win32ole_variant.rb: use skip method to skip the test.
    
    * test/win32ole/test_win32ole_variant_outarg.rb: ditto.

  Modified files:
    trunk/ChangeLog
    trunk/test/win32ole/test_win32ole_variant.rb
    trunk/test/win32ole/test_win32ole_variant_outarg.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 32755)
+++ ChangeLog	(revision 32756)
@@ -1,3 +1,9 @@
+Sat Jul 30 17:26:26 2011  Masaki Suketa <masaki.suketa@n...>
+
+	* test/win32ole/test_win32ole_variant.rb: use skip method to skip the test.
+
+	* test/win32ole/test_win32ole_variant_outarg.rb: ditto.
+
 Sat Jul 30 14:27:00 2011  Kenta Murata  <mrkn@m...>
 
 	* ext/bigdecimal/bigdecimal.c (BigDecimal_version): version 1.1.0.
Index: test/win32ole/test_win32ole_variant.rb
===================================================================
--- test/win32ole/test_win32ole_variant.rb	(revision 32755)
+++ test/win32ole/test_win32ole_variant.rb	(revision 32756)
@@ -4,11 +4,6 @@
 end
 require "test/unit"
 
-$MSGS = []
-def add_skip_message(msg)
-  $MSGS.push msg
-end
-
 if defined?(WIN32OLE_VARIANT)
 
   class TestWIN32OLE_VARIANT < Test::Unit::TestCase
@@ -260,7 +255,7 @@
         assert_equal(-123456789012345, obj.value)
         assert_equal(WIN32OLE::VARIANT::VT_I8|WIN32OLE::VARIANT::VT_BYREF, obj.vartype)
       else
-        STDERR.puts("\n#{__FILE__}:#{__LINE__}:#{self.class.name}.test_s_new_with_i8_byref is skipped")
+        skip("WIN32OLE::VARIANT::VT_I8 is not available")
       end
     end
 
@@ -272,7 +267,7 @@
         assert_equal(123456789012345, obj.value)
         assert_equal(WIN32OLE::VARIANT::VT_UI8|WIN32OLE::VARIANT::VT_BYREF, obj.vartype)
       else
-        STDERR.puts("\n#{__FILE__}:#{__LINE__}:#{self.class.name}.test_s_new_with_ui8_byref is skipped.")
+        skip("WIN32OLE::VARIANT::VT_UI8 is not available")
       end
     end
 
@@ -398,7 +393,7 @@
         begin
           WIN32OLE.locale = 0x0411 # set locale Japanese
         rescue WIN32OLERuntimeError
-          STDERR.puts("\n#{__FILE__}:#{__LINE__}:#{self.class.name}.test_conversion_str2cy is skipped(Japanese locale is not installed)")
+          skip("Japanese locale is not installed")
         end
         if WIN32OLE.locale == 0x0411
           obj = WIN32OLE_VARIANT.new("\\10,000", WIN32OLE::VARIANT::VT_CY)
Index: test/win32ole/test_win32ole_variant_outarg.rb
===================================================================
--- test/win32ole/test_win32ole_variant_outarg.rb	(revision 32755)
+++ test/win32ole/test_win32ole_variant_outarg.rb	(revision 32756)
@@ -23,16 +23,13 @@
 end
 
 if defined?(WIN32OLE_VARIANT)
-  dotest = ado_csv_installed?
-  if !dotest
-    STDERR.puts("\n#{__FILE__} skipped(ActiveX Data Object Library not found.)")
-  end
-  if dotest
     class TestWIN32OLE_VARIANT_OUTARG < Test::Unit::TestCase
       module ADO
       end
       CONNSTR="Driver={Microsoft Text Driver (*.txt; *.csv)};DefaultDir=.;"
       def setup
+        return if !ado_csv_installed?
+
         FileUtils.cp(File.dirname(__FILE__) + '/orig_data.csv', './data.csv')
         @db = WIN32OLE.new('ADODB.Connection')
         if !defined?(ADO::AdStateOpen)
@@ -43,6 +40,9 @@
       end
 
       def test_variant_ref_and_argv
+        if !ado_csv_installed?
+          skip("ActiveX Data Object Library not found")
+        end
         sql = "INSERT INTO data.csv VALUES (5, 'E')"
         @db.execute(sql, -1)
         c = WIN32OLE::ARGV[1]
@@ -58,12 +58,11 @@
       end
 
       def teardown
+        return if !ado_csv_installed?
         if @db && @db.state == ADO::AdStateOpen
           @db.close
         end
         File.unlink("data.csv")
       end
-
     end
-  end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]