nobu	2011-07-28 12:32:52 +0900 (Thu, 28 Jul 2011)

  New Revision: 32720

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=32720

  Log:
    * ext/dl/cptr.c (rb_dlptr_aref, rb_dlptr_aset): check NULL pointer
      dereference.

  Modified files:
    trunk/ChangeLog
    trunk/ext/dl/cptr.c
    trunk/test/dl/test_cptr.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 32719)
+++ ChangeLog	(revision 32720)
@@ -1,5 +1,8 @@
-Thu Jul 28 12:32:46 2011  Nobuyoshi Nakada  <nobu@r...>
+Thu Jul 28 12:32:49 2011  Nobuyoshi Nakada  <nobu@r...>
 
+	* ext/dl/cptr.c (rb_dlptr_aref, rb_dlptr_aset): check NULL pointer
+	  dereference.
+
 	* ext/dl/cptr.c (rb_dlptr_s_to_ptr): use rb_check_funcall.
 
 	* ext/dl/cptr.c (rb_dlptr_s_to_ptr): fix wrapping condition.
Index: ext/dl/cptr.c
===================================================================
--- ext/dl/cptr.c	(revision 32719)
+++ ext/dl/cptr.c	(revision 32720)
@@ -502,16 +502,19 @@
     VALUE arg0, arg1;
     VALUE retval = Qnil;
     size_t offset, len;
+    struct ptr_data *data;
 
+    TypedData_Get_Struct(self, struct ptr_data, &dlptr_data_type, data);
+    if (!data->ptr) rb_raise(rb_eDLError, "NULL pointer dereference");
     switch( rb_scan_args(argc, argv, "11", &arg0, &arg1) ){
       case 1:
 	offset = NUM2ULONG(arg0);
-	retval = INT2NUM(*((char*)RPTR_DATA(self)->ptr + offset));
+	retval = INT2NUM(*((char *)data->ptr + offset));
 	break;
       case 2:
 	offset = NUM2ULONG(arg0);
 	len    = NUM2ULONG(arg1);
-	retval = rb_tainted_str_new((char *)RPTR_DATA(self)->ptr + offset, len);
+	retval = rb_tainted_str_new((char *)data->ptr + offset, len);
 	break;
       default:
 	rb_bug("rb_dlptr_aref()");
@@ -535,17 +538,20 @@
     VALUE retval = Qnil;
     size_t offset, len;
     void *mem;
+    struct ptr_data *data;
 
+    TypedData_Get_Struct(self, struct ptr_data, &dlptr_data_type, data);
+    if (!data->ptr) rb_raise(rb_eDLError, "NULL pointer dereference");
     switch( rb_scan_args(argc, argv, "21", &arg0, &arg1, &arg2) ){
       case 2:
 	offset = NUM2ULONG(arg0);
-	((char*)RPTR_DATA(self)->ptr)[offset] = NUM2UINT(arg1);
+	((char*)data->ptr)[offset] = NUM2UINT(arg1);
 	retval = arg1;
 	break;
       case 3:
 	offset = NUM2ULONG(arg0);
 	len    = NUM2ULONG(arg1);
-	if( TYPE(arg2) == T_STRING ){
+	if (RB_TYPE_P(arg2, T_STRING)) {
 	    mem = StringValuePtr(arg2);
 	}
 	else if( rb_obj_is_kind_of(arg2, rb_cDLCPtr) ){
@@ -554,7 +560,7 @@
 	else{
 	    mem    = NUM2PTR(arg2);
 	}
-	memcpy((char *)RPTR_DATA(self)->ptr + offset, mem, len);
+	memcpy((char *)data->ptr + offset, mem, len);
 	retval = arg2;
 	break;
       default:
Index: test/dl/test_cptr.rb
===================================================================
--- test/dl/test_cptr.rb	(revision 32719)
+++ test/dl/test_cptr.rb	(revision 32720)
@@ -212,5 +212,11 @@
       assert_equal ptr3.to_i, ptr[0,2] = ptr3.to_i
       check.call(str, ptr)
     end
+
+    def test_null_pointer
+      nullpo = CPtr.new(0)
+      assert_raise(DLError) {nullpo[0]}
+      assert_raise(DLError) {nullpo[0] = 1}
+    end
   end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/