[前][次][番号順一覧][スレッド一覧]

ruby-changes:19665

From: drbrain <ko1@a...>
Date: Mon, 23 May 2011 09:21:16 +0900 (JST)
Subject: [ruby-changes:19665] drbrain:r31710 (trunk): * lib/net/smtp.rb: Document Net::SMTP::Response. Patch by J.R. Garcia.

drbrain	2011-05-23 09:21:10 +0900 (Mon, 23 May 2011)

  New Revision: 31710

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=31710

  Log:
    * lib/net/smtp.rb:  Document Net::SMTP::Response.  Patch by J.R. Garcia.
      [Ruby 1.9 - Bug #4768]

  Modified files:
    trunk/ChangeLog
    trunk/lib/net/smtp.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 31709)
+++ ChangeLog	(revision 31710)
@@ -1,3 +1,8 @@
+Mon May 23 09:19:53 2011  Eric Hodel  <drbrain@s...>
+
+	* lib/net/smtp.rb:  Document Net::SMTP::Response.  Patch by J.R. Garcia.
+	  [Ruby 1.9 - Bug #4768]
+
 Mon May 23 09:03:52 2011  Shota Fukumori  <sorah@t...>
 
 	* lib/test/unit/parallel.rb: Never Ignore SIGINT. When received
Index: lib/net/smtp.rb
===================================================================
--- lib/net/smtp.rb	(revision 31709)
+++ lib/net/smtp.rb	(revision 31710)
@@ -967,39 +967,62 @@
       end
     end
 
+    # This class represents a response received by the SMTP server. Instances
+    # of this class are created by the SMTP class; they should not be directly
+    # created by the user. For more information on SMTP responses, view
+    # {Section 4.2 of RFC 5321}[http://tools.ietf.org/html/rfc5321#section-4.2]
     class Response
+      # Parses the received response and separates the reply code and the human
+      # readable reply text
       def self.parse(str)
         new(str[0,3], str)
       end
 
+      # Creates a new instance of the Response class and sets the status and
+      # string attributes
       def initialize(status, string)
         @status = status
         @string = string
       end
 
+      # The three digit reply code of the SMTP response
       attr_reader :status
+
+      # The human readable reply text of the SMTP response
       attr_reader :string
 
+      # Takes the first digit of the reply code to determine the status type
       def status_type_char
         @status[0, 1]
       end
 
+      # Determines whether the response received was a Positive Completion
+      # reply (2xx reply code)
       def success?
         status_type_char() == '2'
       end
 
+      # Determines whether the response received was a Positive Intermediate
+      # reply (3xx reply code)
       def continue?
         status_type_char() == '3'
       end
 
+      # The first line of the human readable reply text
       def message
         @string.lines.first
       end
 
+      # Creates a CRAM-MD5 challenge. You can view more information on CRAM-MD5
+      # on Wikipedia: http://en.wikipedia.org/wiki/CRAM-MD5
       def cram_md5_challenge
         @string.split(/ /)[1].unpack('m')[0]
       end
 
+      # Returns a hash of the human readable reply text in the response if it
+      # is multiple lines. It does not return the first line. The key of the
+      # hash is the first word the value of the hash is an array with each word
+      # thereafter being a value in the array
       def capabilities
         return {} unless @string[3, 1] == '-'
         h = {}
@@ -1010,6 +1033,8 @@
         h
       end
 
+      # Determines whether there was an error and raies the appropriate error
+      # based on the reply code of the response
       def exception_class
         case @status
         when /\A4/  then SMTPServerBusy

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]