naruse	2011-04-08 16:50:49 +0900 (Fri, 08 Apr 2011)

  New Revision: 31248

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=31248

  Log:
    * ext/stringio/stringio.c (strio_getline): check whether str is
      a string when str and lim are given.
      https://twitter.com/watson1978/status/56225052152168449

  Modified files:
    trunk/ChangeLog
    trunk/ext/stringio/stringio.c
    trunk/test/stringio/test_stringio.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 31247)
+++ ChangeLog	(revision 31248)
@@ -1,3 +1,9 @@
+Fri Apr  8 16:01:56 2011  NARUSE, Yui  <naruse@r...>
+
+	* ext/stringio/stringio.c (strio_getline): check whether str is
+	  a string when str and lim are given.
+	  https://twitter.com/watson1978/status/56225052152168449
+
 Thu Apr  7 20:03:52 2011  Tanaka Akira  <akr@f...>
 
 	* include/ruby/io.h: parenthesize macro arguments.
Index: ext/stringio/stringio.c
===================================================================
--- ext/stringio/stringio.c	(revision 31247)
+++ ext/stringio/stringio.c	(revision 31248)
@@ -921,18 +921,17 @@
 {
     const char *s, *e, *p;
     long n, limit = 0;
-    VALUE str;
+    VALUE str, lim;
 
-    if (argc == 0) {
+    rb_scan_args(argc, argv, "02", &str, &lim);
+    switch (argc) {
+      case 0:
 	str = rb_rs;
-    }
-    else {
-	VALUE lim, tmp;
+	break;
 
-	rb_scan_args(argc, argv, "11", &str, &lim);
-	if (!NIL_P(lim)) limit = NUM2LONG(lim);
-	else if (!NIL_P(str) && TYPE(str) != T_STRING) {
-	    tmp = rb_check_string_type(str);
+      case 1:
+	if (!NIL_P(str) && TYPE(str) != T_STRING) {
+	    VALUE tmp = rb_check_string_type(str);
 	    if (NIL_P(tmp)) {
 		limit = NUM2LONG(str);
 		if (limit == 0) return rb_str_new(0,0);
@@ -942,9 +941,12 @@
 		str = tmp;
 	    }
 	}
-	else if (!NIL_P(str)) {
-	    StringValue(str);
-	}
+	break;
+
+      case 2:
+	if (!NIL_P(str)) StringValue(str);
+	limit = NUM2LONG(lim);
+	break;
     }
 
     if (ptr->pos >= (n = RSTRING_LEN(ptr->string))) {
Index: test/stringio/test_stringio.rb
===================================================================
--- test/stringio/test_stringio.rb	(revision 31247)
+++ test/stringio/test_stringio.rb	(revision 31248)
@@ -51,6 +51,8 @@
     assert_equal("abc\n", StringIO.new("abc\n\ndef\n").gets)
     assert_equal("abc\n\ndef\n", StringIO.new("abc\n\ndef\n").gets(nil))
     assert_equal("abc\n\n", StringIO.new("abc\n\ndef\n").gets(""))
+    assert_raise(TypeError){StringIO.new("").gets(1, 1)}
+    assert_raise(TypeError){StringIO.new("").gets(nil, nil)}
   end
 
   def test_readlines

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/