nobu	2011-02-05 10:30:01 +0900 (Sat, 05 Feb 2011)

  New Revision: 30791

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=30791

  Log:
    * ext/json/parser/parser.h (GET_PARSER): check if initialized.
      [ruby-core:35079]
    * ext/json/parser/parser.rl (cParser_initialize): ditto.

  Modified files:
    trunk/ChangeLog
    trunk/ext/json/parser/parser.c
    trunk/ext/json/parser/parser.h
    trunk/ext/json/parser/parser.rl
    trunk/test/json/test_json.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 30790)
+++ ChangeLog	(revision 30791)
@@ -1,3 +1,10 @@
+Sat Feb  5 10:29:52 2011  Nobuyoshi Nakada  <nobu@r...>
+
+	* ext/json/parser/parser.h (GET_PARSER): check if initialized.
+	  [ruby-core:35079]
+
+	* ext/json/parser/parser.rl (cParser_initialize): ditto.
+
 Sat Feb  5 10:09:31 2011  Nobuyoshi Nakada  <nobu@r...>
 
 	* load.c (rb_get_expanded_load_path): always expand load paths.
Index: ext/json/parser/parser.h
===================================================================
--- ext/json/parser/parser.h	(revision 30790)
+++ ext/json/parser/parser.h	(revision 30791)
@@ -44,6 +44,9 @@
 } JSON_Parser;
 
 #define GET_PARSER                          \
+    GET_PARSER_INIT;                        \
+    if (!json->Vsource) rb_raise(rb_eArgError, "uninitialized instance")
+#define GET_PARSER_INIT                     \
     JSON_Parser *json;                      \
     Data_Get_Struct(self, JSON_Parser, json)
 
Index: ext/json/parser/parser.rl
===================================================================
--- ext/json/parser/parser.rl	(revision 30790)
+++ ext/json/parser/parser.rl	(revision 30791)
@@ -608,7 +608,11 @@
     char *ptr;
     long len;
     VALUE source, opts;
-    GET_PARSER;
+    GET_PARSER_INIT;
+
+    if (json->Vsource) {
+        rb_raise(rb_eArgError, "already initialized instance");
+    }
     rb_scan_args(argc, argv, "11", &source, &opts);
     source = convert_encoding(StringValue(source));
     ptr = RSTRING_PTR(source);
@@ -795,5 +799,6 @@
  * Local variables:
  * mode: c
  * c-file-style: ruby
+ * indent-tabs-mode: nil
  * End:
  */
Index: ext/json/parser/parser.c
===================================================================
--- ext/json/parser/parser.c	(revision 30790)
+++ ext/json/parser/parser.c	(revision 30791)
@@ -1610,7 +1610,11 @@
     char *ptr;
     long len;
     VALUE source, opts;
-    GET_PARSER;
+    GET_PARSER_INIT;
+
+    if (json->Vsource) {
+        rb_raise(rb_eArgError, "already initialized instance");
+    }
     rb_scan_args(argc, argv, "11", &source, &opts);
     source = convert_encoding(StringValue(source));
     ptr = RSTRING_PTR(source);
@@ -1698,16 +1702,16 @@
     GET_PARSER;
 
     
-#line 1702 "parser.c"
+#line 1706 "parser.c"
 	{
 	cs = JSON_start;
 	}
 
-#line 699 "parser.rl"
+#line 703 "parser.rl"
     p = json->source;
     pe = p + json->len;
     
-#line 1711 "parser.c"
+#line 1715 "parser.c"
 	{
 	if ( p == pe )
 		goto _test_eof;
@@ -1784,7 +1788,7 @@
 	if ( ++p == pe )
 		goto _test_eof10;
 case 10:
-#line 1788 "parser.c"
+#line 1792 "parser.c"
 	switch( (*p) ) {
 		case 13: goto st10;
 		case 32: goto st10;
@@ -1841,7 +1845,7 @@
 	_out: {}
 	}
 
-#line 702 "parser.rl"
+#line 706 "parser.rl"
 
     if (cs >= JSON_first_final && p == pe) {
         return result;
@@ -1938,5 +1942,6 @@
  * Local variables:
  * mode: c
  * c-file-style: ruby
+ * indent-tabs-mode: nil
  * End:
  */
Index: test/json/test_json.rb
===================================================================
--- test/json/test_json.rb	(revision 30790)
+++ test/json/test_json.rb	(revision 30791)
@@ -391,4 +391,11 @@
     json5 = JSON([orig = 1 << 64])
     assert_equal orig, JSON[json5][0]
   end
+
+  def test_allocate
+    json = JSON::Parser.new("{}")
+    assert_raises(ArgumentError, '[ruby-core:35079]') {json.__send__(:initialize, "{}")}
+    json = JSON::Parser.allocate
+    assert_raises(ArgumentError, '[ruby-core:35079]') {json.source}
+  end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/