nobu	2011-01-25 07:00:55 +0900 (Tue, 25 Jan 2011)

  New Revision: 30648

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=30648

  Log:
    * string.c (rb_string_value_cstr): rb_str_modify can change
      RSTRING_PTR.

  Added files:
    trunk/ext/-test-/string/cstr.c
    trunk/test/-ext-/string/test_cstr.rb
  Modified files:
    trunk/ChangeLog
    trunk/string.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 30647)
+++ ChangeLog	(revision 30648)
@@ -1,3 +1,8 @@
+Tue Jan 25 07:00:52 2011  Nobuyoshi Nakada  <nobu@r...>
+
+	* string.c (rb_string_value_cstr): rb_str_modify can change
+	  RSTRING_PTR.
+
 Tue Jan 25 03:24:28 2011  KOSAKI Motohiro  <kosaki.motohiro@g...>
 
 	* test/ruby/test_thread.rb: Added various ConditionVariable tests.
Index: string.c
===================================================================
--- string.c	(revision 30647)
+++ string.c	(revision 30648)
@@ -1392,7 +1392,11 @@
     if (!s || memchr(s, 0, len)) {
 	rb_raise(rb_eArgError, "string contains null byte");
     }
-    if (s[len]) rb_str_modify(str);
+    if (s[len]) {
+	rb_str_modify(str);
+	s = RSTRING_PTR(str);
+	s[RSTRING_LEN(str)] = 0;
+    }
     return s;
 }
 
Index: ext/-test-/string/cstr.c
===================================================================
--- ext/-test-/string/cstr.c	(revision 0)
+++ ext/-test-/string/cstr.c	(revision 30648)
@@ -0,0 +1,20 @@
+#include "ruby.h"
+
+static VALUE
+bug_str_cstr_term(VALUE str)
+{
+    long len;
+    char *s;
+    rb_str_modify(str);
+    len = RSTRING_LEN(str);
+    RSTRING_PTR(str)[len] = 'x';
+    s = StringValueCStr(str);
+    rb_gc();
+    return INT2NUM(s[len]);
+}
+
+void
+Init_cstr(VALUE klass)
+{
+    rb_define_method(klass, "cstr_term", bug_str_cstr_term, 0);
+}

Property changes on: ext/-test-/string/cstr.c
___________________________________________________________________
Added: svn:eol-style
   + LF

Index: test/-ext-/string/test_cstr.rb
===================================================================
--- test/-ext-/string/test_cstr.rb	(revision 0)
+++ test/-ext-/string/test_cstr.rb	(revision 30648)
@@ -0,0 +1,17 @@
+require 'test/unit'
+require "-test-/string/string"
+
+class Test_StringCStr < Test::Unit::TestCase
+  Bug4319 = '[ruby-dev:43094]'
+
+  def test_embed
+    s = Bug::String.new("abcdef")
+    s.set_len(3)
+    assert_equal(0, s.cstr_term, Bug4319)
+  end
+
+  def test_long
+    s = Bug::String.new("abcdef")*100000
+    assert_equal(0, s.cstr_term, Bug4319)
+  end
+end

Property changes on: test/-ext-/string/test_cstr.rb
___________________________________________________________________
Added: svn:eol-style
   + LF


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/