nobu	2010-12-25 22:04:43 +0900 (Sat, 25 Dec 2010)

  New Revision: 30366

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=30366

  Log:
    * test/csv/test_data_converters.rb, test/csv/test_table.rb: don't
      not call setup within tests.

  Modified files:
    trunk/ChangeLog
    trunk/test/csv/test_data_converters.rb
    trunk/test/csv/test_table.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 30365)
+++ ChangeLog	(revision 30366)
@@ -1,3 +1,8 @@
+Sat Dec 25 22:04:41 2010  Nobuyoshi Nakada  <nobu@r...>
+
+	* test/csv/test_data_converters.rb, test/csv/test_table.rb: don't
+	  not call setup within tests.
+
 Sat Dec 25 20:01:40 2010  KOSAKI Motohiro  <kosaki.motohiro@g...>
 
 	* io.c (pipe_open): Added rb_thread_atfork(). We must reinitialize
Index: test/csv/test_data_converters.rb
===================================================================
--- test/csv/test_data_converters.rb	(revision 30365)
+++ test/csv/test_data_converters.rb	(revision 30366)
@@ -63,24 +63,25 @@
     assert_instance_of(String, CSV::Converters[:date_time]["junk"])
   end
 
-  def test_convert_with_builtin
+  def test_convert_with_builtin_integer
     # setup parser...
     assert(@parser.respond_to?(:convert))
     assert_nothing_raised(Exception) { @parser.convert(:integer) }
 
     # and use
     assert_equal(["Numbers", ":integer", 1, ":float", "3.015"], @parser.shift)
+  end
 
-    setup  # reset
-
+  def test_convert_with_builtin_float
     # setup parser...
+    assert(@parser.respond_to?(:convert))
     assert_nothing_raised(Exception) { @parser.convert(:float) }
 
     # and use
     assert_equal(["Numbers", ":integer", 1.0, ":float", 3.015], @parser.shift)
   end
 
-  def test_convert_order
+  def test_convert_order_float_integer
     # floats first, then integers...
     assert_nothing_raised(Exception) do
       @parser.convert(:float)
@@ -90,9 +91,9 @@
     # gets us nothing but floats
     assert_equal( [String, String, Float, String, Float],
                   @parser.shift.map { |field| field.class } )
+  end
 
-    setup  # reset
-
+  def test_convert_order_integer_float
     # integers have precendance...
     assert_nothing_raised(Exception) do
       @parser.convert(:integer)
@@ -132,9 +133,9 @@
 
     # and use
     assert_equal(["Numbers", :integer, "1", :float, "3.015"], @parser.shift)
+  end
 
-    setup  # reset
-
+  def test_convert_with_custom_code_mix
     # mix built-in and custom...
     assert_nothing_raised(Exception) { @parser.convert(:numeric) }
     assert_nothing_raised(Exception) { @parser.convert(&@custom) }
Index: test/csv/test_table.rb
===================================================================
--- test/csv/test_table.rb	(revision 30365)
+++ test/csv/test_table.rb	(revision 30366)
@@ -270,7 +270,7 @@
     assert_equal(CSV::Row.new(%w[A B C], [13, 14, 15]), @table[-1])
   end
 
-  def test_delete
+  def test_delete_mixed
     ##################
     ### Mixed Mode ###
     ##################
@@ -286,11 +286,12 @@
     2,3
     8,9
     END_RESULT
+  end
 
+  def test_delete_column
     ###################
     ### Column Mode ###
     ###################
-    setup
     @table.by_col!
 
     assert_equal(@rows.map { |row| row[0] }, @table.delete(0))
@@ -303,11 +304,12 @@
     5
     8
     END_RESULT
+  end
 
+  def test_delete_row
     ################
     ### Row Mode ###
     ################
-    setup
     @table.by_row!
 
     assert_equal(@rows[1], @table.delete(1))
@@ -327,7 +329,7 @@
     assert_equal(["ra2", nil, "rb2"], table.delete("col2"))
   end
   
-  def test_delete_if
+  def test_delete_if_row
     ######################
     ### Mixed/Row Mode ###
     ######################
@@ -339,11 +341,12 @@
     A,B,C
     4,5,6
     END_RESULT
+  end
 
+  def test_delete_if_column
     ###################
     ### Column Mode ###
     ###################
-    setup
     @table.by_col!
 
     assert_equal(@table, @table.delete_if { |h, v| h > "A" })

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/