ruby-changes:18233
From: yugui <ko1@a...>
Date: Mon, 20 Dec 2010 22:29:50 +0900 (JST)
Subject: [ruby-changes:18233] Ruby:r30256 (ruby_1_9_2): merges r29803 from trunk into ruby_1_9_2.
yugui 2010-12-20 22:22:29 +0900 (Mon, 20 Dec 2010) New Revision: 30256 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=30256 Log: merges r29803 from trunk into ruby_1_9_2. -- * regparse.c (and_cclass, or_cclass): fix memory leak. Coverity Scan found this bug. [ruby-dev:42579] Modified files: branches/ruby_1_9_2/ChangeLog branches/ruby_1_9_2/regparse.c branches/ruby_1_9_2/version.h Index: ruby_1_9_2/regparse.c =================================================================== --- ruby_1_9_2/regparse.c (revision 30255) +++ ruby_1_9_2/regparse.c (revision 30256) @@ -2006,7 +2006,7 @@ { OnigEncoding enc = env->enc; int r, not1, not2; - BBuf *buf1, *buf2, *pbuf; + BBuf *buf1, *buf2, *pbuf = 0; BitSetRef bsr1, bsr2; BitSet bs1, bs2; @@ -2041,17 +2041,16 @@ else { r = and_code_range_buf(buf1, not1, buf2, not2, &pbuf, env); if (r == 0 && not1 != 0) { - BBuf *tbuf; + BBuf *tbuf = 0; r = not_code_range_buf(enc, pbuf, &tbuf, env); - if (r != 0) { - bbuf_free(pbuf); - return r; - } bbuf_free(pbuf); pbuf = tbuf; } } - if (r != 0) return r; + if (r != 0) { + bbuf_free(pbuf); + return r; + } dest->mbuf = pbuf; bbuf_free(buf1); @@ -2065,7 +2064,7 @@ { OnigEncoding enc = env->enc; int r, not1, not2; - BBuf *buf1, *buf2, *pbuf; + BBuf *buf1, *buf2, *pbuf = 0; BitSetRef bsr1, bsr2; BitSet bs1, bs2; @@ -2100,17 +2099,16 @@ else { r = or_code_range_buf(enc, buf1, not1, buf2, not2, &pbuf, env); if (r == 0 && not1 != 0) { - BBuf *tbuf; + BBuf *tbuf = 0; r = not_code_range_buf(enc, pbuf, &tbuf, env); - if (r != 0) { - bbuf_free(pbuf); - return r; - } bbuf_free(pbuf); pbuf = tbuf; } } - if (r != 0) return r; + if (r != 0) { + bbuf_free(pbuf); + return r; + } dest->mbuf = pbuf; bbuf_free(buf1); Index: ruby_1_9_2/ChangeLog =================================================================== --- ruby_1_9_2/ChangeLog (revision 30255) +++ ruby_1_9_2/ChangeLog (revision 30256) @@ -1,3 +1,8 @@ +Tue Nov 16 00:21:20 2010 Yusuke Endoh <mame@t...> + + * regparse.c (and_cclass, or_cclass): fix memory leak. Coverity Scan + found this bug. [ruby-dev:42579] + Mon Nov 15 23:54:45 2010 Yusuke Endoh <mame@t...> * eval_intern.h (CHECK_STACK_OVERFLOW): it was not intended to add Index: ruby_1_9_2/version.h =================================================================== --- ruby_1_9_2/version.h (revision 30255) +++ ruby_1_9_2/version.h (revision 30256) @@ -1,5 +1,5 @@ #define RUBY_VERSION "1.9.2" -#define RUBY_PATCHLEVEL 96 +#define RUBY_PATCHLEVEL 97 #define RUBY_VERSION_MAJOR 1 #define RUBY_VERSION_MINOR 9 #define RUBY_VERSION_TEENY 1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/