[前][次][番号順一覧][スレッド一覧]

ruby-changes:17897

From: yugui <ko1@a...>
Date: Wed, 24 Nov 2010 18:37:26 +0900 (JST)
Subject: [ruby-changes:17897] Ruby:r29910 (ruby_1_9_2): merges r29257 and r29258 from trunk into ruby_1_9_2.

yugui	2010-11-24 18:37:06 +0900 (Wed, 24 Nov 2010)

  New Revision: 29910

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=29910

  Log:
    merges r29257 and r29258 from trunk into ruby_1_9_2.
    --
    * test/net/imap/test_imap.rb: "localhost" not guaranteed to
      resolve to "127.0.0.1".  On my machine it is "::1" instead.
      The problem is, you have to connect to the imaps server via
      the canonical name written in a server certificate, and that
      of the server.cert is "localhost".  So you have to listen to
      the address of what "localhost" resolves to.  I think this
      situation cannot be resolved in a handy manner because the
      test "test_imaps_post_connection_check" is actually
      expecting to connect to a server via an address other than
      the CN.  On my machine several assertions won't pass because
      the test cannot connect to the server.
    --
    add ChangeLog entry for the previous one.

  Modified files:
    branches/ruby_1_9_2/ChangeLog
    branches/ruby_1_9_2/test/net/imap/test_imap.rb
    branches/ruby_1_9_2/version.h

Index: ruby_1_9_2/ChangeLog
===================================================================
--- ruby_1_9_2/ChangeLog	(revision 29909)
+++ ruby_1_9_2/ChangeLog	(revision 29910)
@@ -1,3 +1,17 @@
+Wed Sep 15 13:37:00 2010  URABE Shyouhei  <shyouhei@r...>
+
+	* test/net/imap/test_imap.rb: "localhost" not guaranteed to
+	  resolve to "127.0.0.1".  On my machine it is "::1" instead.
+	  The problem is, you have to connect to the imaps server via
+	  the canonical name written in a server certificate, and that
+	  of the server.cert is "localhost".  So you have to listen to
+	  the address of what "localhost" resolves to.  I think this
+	  situation cannot be resolved in a handy manner because the
+	  test "test_imaps_post_connection_check" is actually
+	  expecting to connect to a server via an address other than
+	  the CN.  On my machine several assertions won't pass because
+	  the test cannot connect to the server.
+
 Wed Sep 15 09:12:03 2010  Nobuyoshi Nakada  <nobu@r...>
 
 	* io.c (rb_io_puts): fix for wide char encoding strings.
Index: ruby_1_9_2/version.h
===================================================================
--- ruby_1_9_2/version.h	(revision 29909)
+++ ruby_1_9_2/version.h	(revision 29910)
@@ -1,5 +1,5 @@
 #define RUBY_VERSION "1.9.2"
-#define RUBY_PATCHLEVEL 43
+#define RUBY_PATCHLEVEL 44
 #define RUBY_VERSION_MAJOR 1
 #define RUBY_VERSION_MINOR 9
 #define RUBY_VERSION_TEENY 1
Index: ruby_1_9_2/test/net/imap/test_imap.rb
===================================================================
--- ruby_1_9_2/test/net/imap/test_imap.rb	(revision 29909)
+++ ruby_1_9_2/test/net/imap/test_imap.rb	(revision 29910)
@@ -73,7 +73,7 @@
     if defined?(OpenSSL)
       assert_nothing_raised do
         imaps_test do |port|
-          Net::IMAP.new("localhost",
+          Net::IMAP.new(SERVER_ADDR,
                         :port => port,
                         :ssl => { :verify_mode => OpenSSL::SSL::VERIFY_NONE })
         end
@@ -129,7 +129,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         assert_raise(EOFError) do
           imap.logout
         end
@@ -167,7 +167,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         responses = []
         imap.idle do |res|
           responses.push(res)
@@ -219,7 +219,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         begin
           th = Thread.current
           m = Monitor.new
@@ -275,7 +275,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         assert_raise(Net::IMAP::Error) do
           imap.idle_done
         end
@@ -305,7 +305,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         assert_raise(Net::IMAP::ByeResponseError) do
           imap.login("user", "password")
         end
@@ -334,7 +334,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         imap.instance_eval do
           def @sock.shutdown(*args)
             super

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]