[前][次][番号順一覧][スレッド一覧]

ruby-changes:17787

From: mame <ko1@a...>
Date: Mon, 15 Nov 2010 22:48:43 +0900 (JST)
Subject: [ruby-changes:17787] Ruby:r29798 (trunk): * vm_eval.c (rb_funcall): ensure va_end after va_init_list. Coverity

mame	2010-11-15 22:48:37 +0900 (Mon, 15 Nov 2010)

  New Revision: 29798

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=29798

  Log:
    * vm_eval.c (rb_funcall): ensure va_end after va_init_list.  Coverity
      Scan found this bug.

  Modified files:
    trunk/ChangeLog
    trunk/vm_eval.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 29797)
+++ ChangeLog	(revision 29798)
@@ -1,3 +1,8 @@
+Mon Nov 15 22:47:27 2010  Yusuke Endoh  <mame@t...>
+
+	* vm_eval.c (rb_funcall): ensure va_end after va_init_list.  Coverity
+	  Scan found this bug.
+
 Mon Nov 15 08:36:12 2010  Aaron Patterson <aaron@t...>
 
 	* lib/racc/parser.rb (do_parse, yyparse): using class eval to define
Index: vm_eval.c
===================================================================
--- vm_eval.c	(revision 29797)
+++ vm_eval.c	(revision 29798)
@@ -619,11 +619,12 @@
 {
     VALUE *argv;
     va_list ar;
-    va_init_list(ar, n);
 
     if (n > 0) {
 	long i;
 
+	va_init_list(ar, n);
+
 	argv = ALLOCA_N(VALUE, n);
 
 	for (i = 0; i < n; i++) {

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]