nobu	2010-10-29 03:04:23 +0900 (Fri, 29 Oct 2010)

  New Revision: 29622

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=29622

  Log:
    * string.c (rb_str_dump): fix expected length. [ruby-core:32935]

  Modified files:
    trunk/ChangeLog
    trunk/string.c
    trunk/test/ruby/test_stringchar.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 29621)
+++ ChangeLog	(revision 29622)
@@ -1,3 +1,7 @@
+Fri Oct 29 03:04:16 2010  Nobuyoshi Nakada  <nobu@r...>
+
+	* string.c (rb_str_dump): fix expected length. [ruby-core:32935]
+
 Thu Oct 28 23:31:39 2010  Koichi Sasada  <ko1@a...>
 
 	* gc.c (before_gc_sweep, run_final): fix decrement timing of final_num.
Index: string.c
===================================================================
--- string.c	(revision 29621)
+++ string.c	(revision 29622)
@@ -4315,12 +4315,11 @@
 	    }
 	    else {
 		if (u8) {	/* \u{NN} */
-		    char buf[32];
 		    int n = rb_enc_precise_mbclen(p-1, pend, enc);
-		    if (MBCLEN_CHARFOUND_P(n)) {
-			int cc = rb_enc_mbc_to_codepoint(p-1, pend, enc);
-			sprintf(buf, "%x", cc);
-			len += strlen(buf)+4;
+		    if (MBCLEN_CHARFOUND_P(n-1)) {
+			unsigned int cc = rb_enc_mbc_to_codepoint(p-1, pend, enc);
+			while (cc >>= 4) len++;
+			len += 5;
 			p += MBCLEN_CHARFOUND_LEN(n)-1;
 			break;
 		    }
Index: test/ruby/test_stringchar.rb
===================================================================
--- test/ruby/test_stringchar.rb	(revision 29621)
+++ test/ruby/test_stringchar.rb	(revision 29622)
@@ -163,4 +163,19 @@
     s.delete!("a-z")
     assert_equal("BB", s)
   end
+
+  def test_dump
+    bug3996 = '[ruby-core:32935]'
+    Encoding.list.find_all {|enc| enc.ascii_compatible?}.each do |enc|
+      (0..256).map do |c|
+        begin
+          s = c.chr(enc)
+        rescue RangeError, ArgumentError
+          break
+        else
+          assert_not_match(/\0/, s.dump, bug3996)
+        end
+      end
+    end
+  end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/