[前][次][番号順一覧][スレッド一覧]

ruby-changes:17498

From: naruse <ko1@a...>
Date: Fri, 15 Oct 2010 17:28:26 +0900 (JST)
Subject: [ruby-changes:17498] Ruby:r29503 (trunk): * pack.c (pack_pack): simplify comparison of explicit_endian

naruse	2010-10-15 17:28:18 +0900 (Fri, 15 Oct 2010)

  New Revision: 29503

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=29503

  Log:
    * pack.c (pack_pack): simplify comparison of explicit_endian
      as pointed by nobu.
    
    * pack.c (pack_unpack): ditto.

  Modified files:
    trunk/ChangeLog
    trunk/pack.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 29502)
+++ ChangeLog	(revision 29503)
@@ -1,3 +1,10 @@
+Fri Oct 15 17:26:57 2010  NARUSE, Yui  <naruse@r...>
+
+	* pack.c (pack_pack): simplify comparison of explicit_endian
+	  as pointed by nobu.
+
+	* pack.c (pack_unpack): ditto.
+
 Thu Oct 14 09:46:28 2010  NARUSE, Yui  <naruse@r...>
 
 	* sprintf.c (rb_str_format): fix: sprintf with hex format and
Index: pack.c
===================================================================
--- pack.c	(revision 29502)
+++ pack.c	(revision 29503)
@@ -770,7 +770,7 @@
 
           pack_integer:
 	    if (explicit_endian) {
-		bigendian_p = ((explicit_endian - '<') != 0);
+		bigendian_p = explicit_endian == '>';
 	    }
 
             switch (integer_size) {
@@ -1666,7 +1666,7 @@
 
 	  unpack_integer:
 	    if (explicit_endian) {
-		bigendian_p = ((explicit_endian - '<') != 0);
+		bigendian_p = explicit_endian == '>';
 	    }
 
 	    switch (integer_size) {

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]