naruse	2010-10-14 04:17:49 +0900 (Thu, 14 Oct 2010)

  New Revision: 29490

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=29490

  Log:
    * numeric.c (ruby_float_step): fix Numeric#step with infinity unit
      doesn't works well. [ruby-core:32779]

  Modified files:
    trunk/ChangeLog
    trunk/numeric.c
    trunk/test/ruby/test_numeric.rb
    trunk/test/ruby/test_string.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 29489)
+++ ChangeLog	(revision 29490)
@@ -1,3 +1,8 @@
+Thu Oct 14 04:16:41 2010  NARUSE, Yui  <naruse@r...>
+
+	* numeric.c (ruby_float_step): fix Numeric#step with infinity unit
+	  doesn't works well. [ruby-core:32779]
+
 Wed Oct 13 23:16:46 2010  Nobuyoshi Nakada  <nobu@r...>
 
 	* tool/enc-unicode.rb: get rid of lots of warnings.
Index: numeric.c
===================================================================
--- numeric.c	(revision 29489)
+++ numeric.c	(revision 29490)
@@ -1621,7 +1621,7 @@
 	long i;
 
 	if (isinf(unit)) {
-	    if (unit > 0) rb_yield(DBL2NUM(beg));
+	    if (unit > 0 ? beg <= end : beg >= end) rb_yield(DBL2NUM(beg));
 	}
 	else {
 	    if (err>0.5) err=0.5;
Index: test/ruby/test_string.rb
===================================================================
--- test/ruby/test_string.rb	(revision 29489)
+++ test/ruby/test_string.rb	(revision 29490)
@@ -175,11 +175,11 @@
     def o.<=>(x); nil; end
     assert_nil("foo" <=> o)
 
-    class << o;undef <=>;end
+    class << o;remove_method :<=>;end
     def o.<=>(x); 1; end
     assert_equal(-1, "foo" <=> o)
 
-    class << o;undef <=>;end
+    class << o;remove_method :<=>;end
     def o.<=>(x); 2**100; end
     assert_equal(-(2**100), "foo" <=> o)
   end
@@ -202,7 +202,7 @@
     def o.to_str; end
     def o.==(x); false; end
     assert_equal(false, "foo" == o)
-    class << o;undef ==;end
+    class << o;remove_method :==;end
     def o.==(x); true; end
     assert_equal(true, "foo" == o)
   end
@@ -1818,7 +1818,7 @@
       c.class_eval { attr 1 }
     end
 
-    class << o;undef to_str;end
+    class << o;remove_method :to_str;end
     def o.to_str; "foo"; end
     assert_nothing_raised do
       c.class_eval { attr o }
Index: test/ruby/test_numeric.rb
===================================================================
--- test/ruby/test_numeric.rb	(revision 29489)
+++ test/ruby/test_numeric.rb	(revision 29490)
@@ -27,6 +27,7 @@
     assert_raise(ArgumentError) { 1 <= a }
 
     DummyNumeric.class_eval do
+      remove_method :coerce
       def coerce(x); 1.coerce(x); end
     end
     assert_equal(2, 1 + a)
@@ -34,6 +35,7 @@
     assert(1 <= a)
 
     DummyNumeric.class_eval do
+      remove_method :coerce
       def coerce(x); [x, 1]; end
     end
     assert_equal(-1, -a)
@@ -95,6 +97,7 @@
     assert_equal(:ok, a.abs)
 
     DummyNumeric.class_eval do
+      remove_method :<
       def <(x); false; end
     end
 
@@ -150,6 +153,7 @@
     assert_equal(1, a.truncate)
 
     DummyNumeric.class_eval do
+      remove_method :to_f
       def to_f; 1.4; end
     end
 
@@ -160,6 +164,7 @@
     assert_equal(1, a.truncate)
 
     DummyNumeric.class_eval do
+      remove_method :to_f
       def to_f; -1.5; end
     end
 
@@ -202,6 +207,14 @@
     a = []
     10.step(1, -(2**32)) {|x| a << x }
     assert_equal([10], a)
+
+    a = []
+    1.step(0, Float::INFINITY) {|x| a << x }
+    assert_equal([], a)
+
+    a = []
+    0.step(1, -Float::INFINITY) {|x| a << x }
+    assert_equal([], a)
   end
 
   def test_num2long

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/