shyouhei	2010-09-15 13:37:45 +0900 (Wed, 15 Sep 2010)

  New Revision: 29257

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=29257

  Log:
    * test/net/imap/test_imap.rb: "localhost" not guaranteed to
      resolve to "127.0.0.1".  On my machine it is "::1" instead.
      The problem is, you have to connect to the imaps server via
      the canonical name written in a server certificate, and that
      of the server.cert is "localhost".  So you have to listen to
      the address of what "localhost" resolves to.  I think this
      situation cannot be resolved in a handy manner because the
      test "test_imaps_post_connection_check" is actually
      expecting to connect to a server via an address other than
      the CN.  On my machine several assertions won't pass because
      the test cannot connect to the server.

  Modified files:
    trunk/test/net/imap/test_imap.rb

Index: test/net/imap/test_imap.rb
===================================================================
--- test/net/imap/test_imap.rb	(revision 29256)
+++ test/net/imap/test_imap.rb	(revision 29257)
@@ -73,7 +73,7 @@
     if defined?(OpenSSL)
       assert_nothing_raised do
         imaps_test do |port|
-          Net::IMAP.new("localhost",
+          Net::IMAP.new(SERVER_ADDR,
                         :port => port,
                         :ssl => { :verify_mode => OpenSSL::SSL::VERIFY_NONE })
         end
@@ -129,7 +129,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         assert_raise(EOFError) do
           imap.logout
         end
@@ -167,7 +167,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         responses = []
         imap.idle do |res|
           responses.push(res)
@@ -219,7 +219,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         begin
           th = Thread.current
           m = Monitor.new
@@ -275,7 +275,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         assert_raise(Net::IMAP::Error) do
           imap.idle_done
         end
@@ -305,7 +305,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         assert_raise(Net::IMAP::ByeResponseError) do
           imap.login("user", "password")
         end
@@ -334,7 +334,7 @@
     end
     begin
       begin
-        imap = Net::IMAP.new("localhost", :port => port)
+        imap = Net::IMAP.new(SERVER_ADDR, :port => port)
         imap.instance_eval do
           def @sock.shutdown(*args)
             super

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/