ruby-changes:16661
From: mame <ko1@a...>
Date: Fri, 16 Jul 2010 22:09:58 +0900 (JST)
Subject: [ruby-changes:16661] Ruby:r28657 (trunk): * lib/test/unit.rb, bin/testrb, test/runner.rb: revert r28655, which
mame 2010-07-16 22:09:44 +0900 (Fri, 16 Jul 2010) New Revision: 28657 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=28657 Log: * lib/test/unit.rb, bin/testrb, test/runner.rb: revert r28655, which broke test-all. Modified files: trunk/ChangeLog trunk/bin/testrb trunk/lib/test/unit.rb trunk/test/runner.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 28656) +++ ChangeLog (revision 28657) @@ -1,3 +1,8 @@ +Fri Jul 16 22:08:10 2010 Yusuke Endoh <mame@t...> + + * lib/test/unit.rb, bin/testrb, test/runner.rb: revert r28655, which + broke test-all. + Fri Jul 16 14:58:38 2010 Nobuyoshi Nakada <nobu@r...> * lib/test/unit.rb (Test::Unit.setup_argv): run tests only when Index: lib/test/unit.rb =================================================================== --- lib/test/unit.rb (revision 28656) +++ lib/test/unit.rb (revision 28657) @@ -9,21 +9,7 @@ module Unit TEST_UNIT_IMPLEMENTATION = 'test/unit compatibility layer using minitest' - @@installed_at_exit = true - @@run_count = 0 - - RunCount = Module.new do - def run(*) - @@run_count += 1 - super - end - end - - def self.new(*) - super.extend(RunCount) - end - - def self.setup_argv(original_argv=::ARGV) + def self.setup_argv(original_argv=ARGV) minitest_argv = [] files = [] reject = [] @@ -81,23 +67,9 @@ end } - at_exit { - next if @@run_count.nonzero? - next if $! # don't run if there was an exception - exit false unless run(minitest_argv) - } unless @@installed_at_exit - @@installed_at_exit = true - - minitest_argv + ARGV.replace minitest_argv end - - def self.run(args) - exit_code = MiniTest::Unit.new.run(args) - !exit_code || exit_code == 0 - end - - def self.start(argv=::ARGV, &block) - run(setup_argv(argv, &block)) - end end end + +MiniTest::Unit.autorun Index: bin/testrb =================================================================== --- bin/testrb (revision 28656) +++ bin/testrb (revision 28657) @@ -1,9 +1,9 @@ #!/usr/bin/env ruby require 'test/unit' -exit Test::Unit.start {|files| +Test::Unit.setup_argv {|files| if files.empty? puts "Usage: testrb [options] tests..." - exit false + exit 1 end if files.size == 1 $0 = File.basename(files[0]) Index: test/runner.rb =================================================================== --- test/runner.rb (revision 28656) +++ test/runner.rb (revision 28657) @@ -6,7 +6,7 @@ src_testdir = File.dirname(File.expand_path(__FILE__)) srcdir = File.dirname(src_testdir) -exit Test::Unit.start {|files| +Test::Unit.setup_argv {|files| if files.empty? [src_testdir] else -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/