[前][次][番号順一覧][スレッド一覧]

ruby-changes:16635

From: nobu <ko1@a...>
Date: Tue, 13 Jul 2010 21:28:50 +0900 (JST)
Subject: [ruby-changes:16635] Ruby:r28629 (trunk): * process.c (rb_fork_err): suppress gcc 4.4 warnings.

nobu	2010-07-13 21:28:37 +0900 (Tue, 13 Jul 2010)

  New Revision: 28629

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=28629

  Log:
    * process.c (rb_fork_err): suppress gcc 4.4 warnings.
    
    * random.c (fill_random_seed): ditto.

  Modified files:
    trunk/ChangeLog
    trunk/process.c
    trunk/random.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 28628)
+++ ChangeLog	(revision 28629)
@@ -1,3 +1,9 @@
+Tue Jul 13 21:28:35 2010  Nobuyoshi Nakada  <nobu@r...>
+
+	* process.c (rb_fork_err): suppress gcc 4.4 warnings.
+
+	* random.c (fill_random_seed): ditto.
+
 Tue Jul 13 21:01:44 2010  Nobuyoshi Nakada  <nobu@r...>
 
 	* ext/pty/pty.c (establishShell): chfunc must not raise any
Index: process.c
===================================================================
--- process.c	(revision 28628)
+++ process.c	(revision 28629)
@@ -2513,10 +2513,12 @@
 	    if (!(*chfunc)(charg, errmsg, errmsg_buflen)) _exit(EXIT_SUCCESS);
 #ifdef FD_CLOEXEC
 	    err = errno;
-	    (void)write(ep[1], &err, sizeof(err));
+	    if (write(ep[1], &err, sizeof(err)) < 0) err = errno;
             if (errmsg && 0 < errmsg_buflen) {
                 errmsg[errmsg_buflen-1] = '\0';
-                (void)write(ep[1], errmsg, strlen(errmsg));
+                errmsg_buflen = strlen(errmsg);
+		if (errmsg_buflen > 0 &&write(ep[1], errmsg, errmsg_buflen) < 0)
+                  err = errno;
             }
 #endif
 #if EXIT_SUCCESS == 127
Index: random.c
===================================================================
--- random.c	(revision 28628)
+++ random.c	(revision 28629)
@@ -489,7 +489,9 @@
 #endif
             )) >= 0) {
         if (fstat(fd, &statbuf) == 0 && S_ISCHR(statbuf.st_mode)) {
-            (void)read(fd, seed, DEFAULT_SEED_LEN);
+	    if (read(fd, seed, DEFAULT_SEED_LEN) < DEFAULT_SEED_LEN) {
+		/* abandon */;
+	    }
         }
         close(fd);
     }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]