[前][次][番号順一覧][スレッド一覧]

ruby-changes:15117

From: nobu <ko1@a...>
Date: Sun, 21 Mar 2010 09:43:26 +0900 (JST)
Subject: [ruby-changes:15117] Ruby:r26994 (trunk): * io.c (IO_[CRW]BUF_CAPA_MIN): replaced magic numbers.

nobu	2010-03-21 09:43:07 +0900 (Sun, 21 Mar 2010)

  New Revision: 26994

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=26994

  Log:
    * io.c (IO_[CRW]BUF_CAPA_MIN): replaced magic numbers.

  Modified files:
    trunk/ChangeLog
    trunk/io.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 26993)
+++ ChangeLog	(revision 26994)
@@ -1,3 +1,7 @@
+Sun Mar 21 09:43:01 2010  Nobuyoshi Nakada  <nobu@r...>
+
+	* io.c (IO_[CRW]BUF_CAPA_MIN): replaced magic numbers.
+
 Sun Mar 21 09:22:10 2010  Tanaka Akira  <akr@f...>
 
 	* object.c (rb_obj_hash): use LONG2FIX to avoid Bignum allocation.
Index: io.c
===================================================================
--- io.c	(revision 26993)
+++ io.c	(revision 26994)
@@ -109,6 +109,10 @@
 
 #define numberof(array) (int)(sizeof(array) / sizeof((array)[0]))
 
+#define IO_RBUF_CAPA_MIN 16384
+#define IO_CBUF_CAPA_MIN 16384
+#define IO_WBUF_CAPA_MIN  8192
+
 VALUE rb_cIO;
 VALUE rb_eEOFError;
 VALUE rb_eIOError;
@@ -338,10 +342,10 @@
 	if (len > INT_MAX)
 	    rb_raise(rb_eIOError, "ungetbyte failed");
 #endif
-	if (len > 8192)
+	if (len > IO_RBUF_CAPA_MIN)
 	    fptr->rbuf_capa = (int)len;
 	else
-	    fptr->rbuf_capa = 8192;
+	    fptr->rbuf_capa = IO_RBUF_CAPA_MIN;
         fptr->rbuf = ALLOC_N(char, fptr->rbuf_capa);
     }
     if (fptr->rbuf_capa < len + fptr->rbuf_len) {
@@ -799,7 +803,7 @@
     if (fptr->wbuf == NULL && !(!nosync && (fptr->mode & FMODE_SYNC))) {
         fptr->wbuf_off = 0;
         fptr->wbuf_len = 0;
-        fptr->wbuf_capa = 8192;
+        fptr->wbuf_capa = IO_WBUF_CAPA_MIN;
         fptr->wbuf = ALLOC_N(char, fptr->wbuf_capa);
 	fptr->write_lock = rb_mutex_new();
     }
@@ -1171,7 +1175,7 @@
     if (fptr->rbuf == NULL) {
         fptr->rbuf_off = 0;
         fptr->rbuf_len = 0;
-        fptr->rbuf_capa = 8192;
+        fptr->rbuf_capa = IO_RBUF_CAPA_MIN;
         fptr->rbuf = ALLOC_N(char, fptr->rbuf_capa);
     }
     if (fptr->rbuf_len == 0) {
@@ -1426,7 +1430,7 @@
 {
     rb_io_t *fptr;
     const char *cname;
-    char fd_desc[256];
+    char fd_desc[4+sizeof(int)*3];
     const char *path;
     const char *st = "";
 
@@ -1587,7 +1591,8 @@
             rb_exc_raise(rb_econv_open_exc(sname, dname, ecflags));
         fptr->cbuf_off = 0;
         fptr->cbuf_len = 0;
-        fptr->cbuf_capa = size < 1024 ? 1024 : size;
+	if (size < IO_CBUF_CAPA_MIN) size = IO_CBUF_CAPA_MIN;
+        fptr->cbuf_capa = size;
         fptr->cbuf = ALLOC_N(char, fptr->cbuf_capa);
     }
 }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]