ruby-changes:12610
From: nobu <ko1@a...>
Date: Thu, 30 Jul 2009 16:46:02 +0900 (JST)
Subject: [ruby-changes:12610] Ruby:r24321 (trunk): * insns.def (defineclass): preserve encoding of class/module
nobu 2009-07-30 16:45:42 +0900 (Thu, 30 Jul 2009) New Revision: 24321 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=24321 Log: * insns.def (defineclass): preserve encoding of class/module names. [ruby-core:24600] * variable.c (rb_set_class_path_string): set class path with a string value. Modified files: trunk/ChangeLog trunk/include/ruby/intern.h trunk/insns.def trunk/test/ruby/test_class.rb trunk/test/ruby/test_module.rb trunk/variable.c Index: include/ruby/intern.h =================================================================== --- include/ruby/intern.h (revision 24320) +++ include/ruby/intern.h (revision 24321) @@ -759,6 +759,7 @@ VALUE rb_mod_name(VALUE); VALUE rb_class_path(VALUE); void rb_set_class_path(VALUE, VALUE, const char*); +void rb_set_class_path_string(VALUE, VALUE, VALUE); VALUE rb_path2class(const char*); void rb_name_class(VALUE, ID); VALUE rb_class_name(VALUE); Index: ChangeLog =================================================================== --- ChangeLog (revision 24320) +++ ChangeLog (revision 24321) @@ -1,3 +1,11 @@ +Thu Jul 30 16:45:39 2009 Nobuyoshi Nakada <nobu@r...> + + * insns.def (defineclass): preserve encoding of class/module + names. [ruby-core:24600] + + * variable.c (rb_set_class_path_string): set class path with a + string value. + Thu Jul 30 16:12:48 2009 Nobuyoshi Nakada <nobu@r...> * variable.c (Init_var_tables): initializes __classid__ ID. Index: insns.def =================================================================== --- insns.def (revision 24320) +++ insns.def (revision 24321) @@ -909,7 +909,7 @@ else { /* new class declaration */ klass = rb_define_class_id(id, super); - rb_set_class_path(klass, cbase, rb_id2name(id)); + rb_set_class_path_string(klass, cbase, rb_id2str(id)); rb_const_set(cbase, id, klass); rb_class_inherited(super, klass); } @@ -936,7 +936,7 @@ else { /* new module declaration */ klass = rb_define_module_id(id); - rb_set_class_path(klass, cbase, rb_id2name(id)); + rb_set_class_path_string(klass, cbase, rb_id2str(id)); rb_const_set(cbase, id, klass); } break; Index: variable.c =================================================================== --- variable.c (revision 24320) +++ variable.c (revision 24321) @@ -215,6 +215,23 @@ } void +rb_set_class_path_string(VALUE klass, VALUE under, VALUE name) +{ + VALUE str; + + if (under == rb_cObject) { + str = rb_str_new_frozen(name); + } + else { + str = rb_str_dup(rb_class_path(under)); + rb_str_cat2(str, "::"); + rb_str_append(str, name); + OBJ_FREEZE(str); + } + rb_ivar_set(klass, classpath, str); +} + +void rb_set_class_path(VALUE klass, VALUE under, const char *name) { VALUE str; Index: test/ruby/test_module.rb =================================================================== --- test/ruby/test_module.rb (revision 24320) +++ test/ruby/test_module.rb (revision 24321) @@ -741,4 +741,12 @@ assert_equal(:bClass2, b.__send__(:bClass2)) assert_equal(:bClass3, b.__send__(:bClass3)) end + + + def test_nonascii_name + c = eval("class ::C\u{df}; self; end") + assert_equal("C\u{df}", c.name, '[ruby-core:24600]') + c = eval("class C\u{df}; self; end") + assert_equal("TestModule::C\u{df}", c.name, '[ruby-core:24600]') + end end Index: test/ruby/test_class.rb =================================================================== --- test/ruby/test_class.rb (revision 24320) +++ test/ruby/test_class.rb (revision 24321) @@ -144,4 +144,11 @@ assert_raise(TypeError) { Class.allocate.new } assert_raise(TypeError) { Class.allocate.superclass } end + + def test_nonascii_name + c = eval("class ::C\u{df}; self; end") + assert_equal("C\u{df}", c.name, '[ruby-core:24600]') + c = eval("class C\u{df}; self; end") + assert_equal("TestClass::C\u{df}", c.name, '[ruby-core:24600]') + end end -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/