ruby-changes:12189
From: kou <ko1@a...>
Date: Sat, 27 Jun 2009 13:45:42 +0900 (JST)
Subject: [ruby-changes:12189] Ruby:r23867 (trunk): * NEWS, lib/rss/maker/base.rb, test/rss/test_maker_2.0.rb: add
kou 2009-06-27 13:45:24 +0900 (Sat, 27 Jun 2009) New Revision: 23867 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=23867 Log: * NEWS, lib/rss/maker/base.rb, test/rss/test_maker_2.0.rb: add item.guid.permanent_link? and item.guid.permanent_link=. Modified files: trunk/ChangeLog trunk/NEWS trunk/lib/rss/maker/base.rb trunk/test/rss/test_maker_2.0.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 23866) +++ ChangeLog (revision 23867) @@ -1,3 +1,8 @@ +Sat Jun 27 13:44:48 2009 Kouhei Sutou <kou@c...> + + * NEWS, lib/rss/maker/base.rb, test/rss/test_maker_2.0.rb: add + item.guid.permanent_link? and item.guid.permanent_link=. + Sat Jun 27 13:41:00 2009 Kouhei Sutou <kou@c...> * NEWS: rss: 0.2.5 -> 0.2.7. Index: lib/rss/maker/base.rb =================================================================== --- lib/rss/maker/base.rb (revision 23866) +++ lib/rss/maker/base.rb (revision 23867) @@ -746,6 +746,14 @@ attr_accessor element add_need_initialize_variable(element) end + + def permanent_link? + isPermaLink + end + + def permanent_link=(bool) + self.isPermaLink = bool + end end class EnclosureBase < Base Index: NEWS =================================================================== --- NEWS (revision 23866) +++ NEWS (revision 23867) @@ -84,6 +84,11 @@ * RSS::Maker.supported?(version) * new method to check whether given version is supported. + * RSS::Maker: item.guid.permanent_link? + * new alias of item.guid.isPermaLink + * RSS::Maker: item.guid.permanent_link= + * new alias of item.guid.isPermaLink= + * REXML * REXML::Document.entity_expansion_limit= Index: test/rss/test_maker_2.0.rb =================================================================== --- test/rss/test_maker_2.0.rb (revision 23866) +++ test/rss/test_maker_2.0.rb (revision 23867) @@ -488,6 +488,26 @@ assert_equal(content, guid.content) end + def test_guid_permanent_link + content = "http://inessential.com/2002/09/01.php#a2" + + rss = RSS::Maker.make("2.0") do |maker| + setup_dummy_channel(maker) + setup_dummy_item(maker) + + guid = maker.items.last.guid + assert_equal(nil, guid.permanent_link?) + assert_equal(guid.isPermaLink, guid.permanent_link?) + guid.permanent_link = true + assert_equal(true, guid.permanent_link?) + assert_equal(guid.isPermaLink, guid.permanent_link?) + guid.content = content + end + guid = rss.channel.items.last.guid + assert_equal(true, guid.isPermaLink) + assert_equal(content, guid.content) + end + def test_not_valid_guid content = "http://inessential.com/2002/09/01.php#a2" -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/