ruby-changes:12038
From: matz <ko1@a...>
Date: Tue, 16 Jun 2009 23:47:08 +0900 (JST)
Subject: [ruby-changes:12038] Ruby:r23705 (trunk): * io.c (fptr_finalize): revert last change.
matz 2009-06-16 23:46:53 +0900 (Tue, 16 Jun 2009) New Revision: 23705 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=23705 Log: * io.c (fptr_finalize): revert last change. [ruby-dev:38648] * io.c (fptr_finalize): skip close(2) for fd 0,1,2. Modified files: trunk/ChangeLog trunk/io.c Index: ChangeLog =================================================================== --- ChangeLog (revision 23704) +++ ChangeLog (revision 23705) @@ -1,3 +1,9 @@ +Tue Jun 16 22:47:37 2009 Yukihiro Matsumoto <matz@r...> + + * io.c (fptr_finalize): revert last change. [ruby-dev:38648] + + * io.c (fptr_finalize): skip close(2) for fd 0,1,2. + Tue Jun 16 20:07:09 2009 NARUSE, Yui <naruse@r...> * transcode.c (transcode_restartable0): refix can't build with VC9. Index: io.c =================================================================== --- io.c (revision 23704) +++ io.c (revision 23705) @@ -3221,8 +3221,8 @@ if (io_fflush(fptr) < 0 && NIL_P(err)) err = noraise ? Qtrue : INT2NUM(errno); } - if (noraise && (IS_PREP_STDIO(fptr) || fptr->fd <= 2)) { - goto check_err; + if (IS_PREP_STDIO(fptr) || fptr->fd <= 2) { + goto skip_fd_close; } if (fptr->stdio_file) { /* fptr->stdio_file is deallocated anyway @@ -3237,11 +3237,11 @@ if (close(fptr->fd) < 0 && NIL_P(err)) err = noraise ? Qtrue : INT2NUM(errno); } + skip_fd_close: fptr->fd = -1; fptr->stdio_file = 0; fptr->mode &= ~(FMODE_READABLE|FMODE_WRITABLE); - check_err: if (!NIL_P(err) && !noraise) { switch(TYPE(err)) { case T_FIXNUM: -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/