nobu	2009-02-19 15:39:52 +0900 (Thu, 19 Feb 2009)

  New Revision: 22440

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=22440

  Log:
    * ext/openssl/ossl_ocsp.c (ossl_ocspbres_verify): OCSP_basic_verify
      returns positive value on success, not non-zero.  [ruby-core:21762]

  Modified files:
    trunk/ChangeLog
    trunk/ext/openssl/ossl_ocsp.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 22439)
+++ ChangeLog	(revision 22440)
@@ -1,3 +1,8 @@
+Thu Feb 19 15:39:50 2009  Nobuyoshi Nakada  <nobu@r...>
+
+	* ext/openssl/ossl_ocsp.c (ossl_ocspbres_verify): OCSP_basic_verify
+	  returns positive value on success, not non-zero.  [ruby-core:21762]
+
 Thu Feb 19 15:17:00 2009  Nobuyoshi Nakada  <nobu@r...>
 
 	* lib/tmpdir.rb (@@systmpdir): File.expand_path also joins paths.
Index: ext/openssl/ossl_ocsp.c
===================================================================
--- ext/openssl/ossl_ocsp.c	(revision 22439)
+++ ext/openssl/ossl_ocsp.c	(revision 22440)
@@ -593,22 +593,22 @@
 static VALUE
 ossl_ocspbres_verify(int argc, VALUE *argv, VALUE self)
 {
-    VALUE certs, store, flags;
+    VALUE certs, store, flags, result;
     OCSP_BASICRESP *bs;
     STACK_OF(X509) *x509s;
     X509_STORE *x509st;
-    int flg, result;
+    int flg;
 
     rb_scan_args(argc, argv, "21", &certs, &store, &flags);
     x509st = GetX509StorePtr(store);
     flg = NIL_P(flags) ? 0 : INT2NUM(flags);
     x509s = ossl_x509_ary2sk(certs);
     GetOCSPBasicRes(self, bs);
-    result = OCSP_basic_verify(bs, x509s, x509st, flg);
+    result = OCSP_basic_verify(bs, x509s, x509st, flg) > 0 ? Qtrue : Qfalse;
     sk_X509_pop_free(x509s, X509_free);
     if(!result) rb_warn("%s", ERR_error_string(ERR_peek_error(), NULL));
 
-    return result ? Qtrue : Qfalse;
+    return result;
 }
 
 /*

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/