[前][次][番号順一覧][スレッド一覧]

ruby-changes:10153

From: yugui <ko1@a...>
Date: Tue, 20 Jan 2009 19:15:45 +0900 (JST)
Subject: [ruby-changes:10153] Ruby:r21697 (ruby_1_9_1): * reverts r21693.

yugui	2009-01-20 19:14:18 +0900 (Tue, 20 Jan 2009)

  New Revision: 21697

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=21697

  Log:
    * reverts r21693.

  Modified files:
    branches/ruby_1_9_1/ChangeLog
    branches/ruby_1_9_1/array.c
    branches/ruby_1_9_1/enum.c
    branches/ruby_1_9_1/test/ruby/test_array.rb
    branches/ruby_1_9_1/test/ruby/test_enum.rb

Index: ruby_1_9_1/array.c
===================================================================
--- ruby_1_9_1/array.c	(revision 21696)
+++ ruby_1_9_1/array.c	(revision 21697)
@@ -2209,11 +2209,9 @@
 static VALUE
 take_items(VALUE obj, long n)
 {
-    VALUE result = to_ary(obj);
+    VALUE result = rb_ary_new2(n);
     VALUE args[2];
 
-    if (!NIL_P(result)) return rb_ary_subseq(result, 0, n);
-    result = rb_ary_new2(n);
     args[0] = result; args[1] = (VALUE)n;
     rb_block_call(obj, rb_intern("each"), 0, 0, take_i, (VALUE)args);
     return result;
Index: ruby_1_9_1/ChangeLog
===================================================================
--- ruby_1_9_1/ChangeLog	(revision 21696)
+++ ruby_1_9_1/ChangeLog	(revision 21697)
@@ -1,3 +1,7 @@
+Tue Jan 20 19:12:18 2009  Yuki Sonoda (Yugui)  <yugui@y...>
+
+	* reverts r21693.
+
 Tue Jan 20 18:49:59 2009  Yuki Sonoda (Yugui)  <yugui@y...>
 
 	* lib/rdoc/ri/path.rb: Gem::Enable was removed.
Index: ruby_1_9_1/enum.c
===================================================================
--- ruby_1_9_1/enum.c	(revision 21696)
+++ ruby_1_9_1/enum.c	(revision 21697)
@@ -1558,17 +1558,13 @@
     ID conv;
     NODE *memo;
     VALUE result = Qnil;
-    VALUE args = rb_ary_new4(argc, argv);
     int allary = Qtrue;
 
-    argv = RARRAY_PTR(args);
     for (i=0; i<argc; i++) {
-	VALUE ary = rb_check_array_type(argv[i]);
-	if (NIL_P(ary)) {
+	if (TYPE(argv[i]) != T_ARRAY) {
 	    allary = Qfalse;
 	    break;
 	}
-	argv[i] = ary;
     }
     if (!allary) {
 	CONST_ID(conv, "to_enum");
@@ -1580,7 +1576,7 @@
 	result = rb_ary_new();
     }
     /* use NODE_DOT2 as memo(v, v, -) */
-    memo = rb_node_newnode(NODE_DOT2, result, args, 0);
+    memo = rb_node_newnode(NODE_DOT2, result, rb_ary_new4(argc, argv), 0);
     rb_block_call(obj, id_each, 0, 0, allary ? zip_ary : zip_i, (VALUE)memo);
 
     return result;
Index: ruby_1_9_1/test/ruby/test_array.rb
===================================================================
--- ruby_1_9_1/test/ruby/test_array.rb	(revision 21696)
+++ ruby_1_9_1/test/ruby/test_array.rb	(revision 21697)
@@ -1502,11 +1502,6 @@
     a = []
     [1, 2, 3].zip([:a, :b], ["a", "b", "c", "d"]) {|x| a << x }
     assert_equal([[1, :a, "a"], [2, :b, "b"], [3, nil, "c"]], a)
-
-    ary = Object.new
-    def ary.to_a;   [1, 2]; end
-    def ary.to_ary; [3, 4]; end
-    assert_equal([[5, 3], [6, 4]], [5, 6].zip(ary))
   end
 
   def test_transpose
Index: ruby_1_9_1/test/ruby/test_enum.rb
===================================================================
--- ruby_1_9_1/test/ruby/test_enum.rb	(revision 21696)
+++ ruby_1_9_1/test/ruby/test_enum.rb	(revision 21697)
@@ -211,11 +211,6 @@
     a = []
     @obj.zip([:a, :b, :c]) {|x,y| a << [x, y] }
     assert_equal([[1,:a],[2,:b],[3,:c],[1,nil],[2,nil]], a)
-
-    ary = Object.new
-    def ary.to_a;   [1, 2]; end
-    def ary.to_ary; [3, 4]; end
-    assert_equal([[1, 3], [2, 4], [3, nil], [1, nil], [2, nil]], @obj.zip(ary))
   end
 
   def test_take

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]