[前][次][番号順一覧][スレッド一覧]

ruby-changes:61493

From: Hiroshi <ko1@a...>
Date: Fri, 5 Jun 2020 07:33:24 +0900 (JST)
Subject: [ruby-changes:61493] 1ab410caf8 (master): Revert "Fix a failure in bundle version with version outputs the version with build metadata"

https://git.ruby-lang.org/ruby.git/commit/?id=1ab410caf8

From 1ab410caf8612589b37309b8cb1fa2f50bb1e097 Mon Sep 17 00:00:00 2001
From: Hiroshi SHIBATA <hsbt@r...>
Date: Thu, 4 Jun 2020 20:31:11 +0900
Subject: Revert "Fix a failure in bundle version with version outputs the
 version with build metadata"

This reverts commit fcc8be0198a16cc5fa7d4827be0c781209b70f98.

diff --git a/spec/bundler/support/helpers.rb b/spec/bundler/support/helpers.rb
index 586603f..731a2d9 100644
--- a/spec/bundler/support/helpers.rb
+++ b/spec/bundler/support/helpers.rb
@@ -329,10 +329,9 @@ module Spec https://github.com/ruby/ruby/blob/trunk/spec/bundler/support/helpers.rb#L329
 
         replace_version_file(version, dir: build_path) # rubocop:disable Style/HashSyntax
 
-        sys_exec("git rev-parse --short HEAD", :dir => source_root)
         build_metadata = {
           :built_at => loaded_gemspec.date.utc.strftime("%Y-%m-%d"),
-          :git_commit_sha => exitstatus.zero? ? out.strip : "unknown",
+          :git_commit_sha => sys_exec("git rev-parse --short HEAD", :dir => source_root).strip,
         }
 
         replace_build_metadata(build_metadata, dir: build_path) # rubocop:disable Style/HashSyntax
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]