[前][次][番号順一覧][スレッド一覧]

ruby-changes:59008

From: Yuki <ko1@a...>
Date: Sun, 1 Dec 2019 11:08:43 +0900 (JST)
Subject: [ruby-changes:59008] 0fef526606 (master): Do not call 'gem "did_you_mean"' for now

https://git.ruby-lang.org/ruby.git/commit/?id=0fef526606

From 0fef526606c72e7d2a3c83aebd9204da34016d96 Mon Sep 17 00:00:00 2001
From: Yuki Nishijima <yk.nishijima@g...>
Date: Fri, 29 Nov 2019 21:40:07 -0500
Subject: Do not call 'gem "did_you_mean"' for now

This will slow down the time that the +require+ method takes to load DYM,
but this has caused a build failure in a certain situation:

  https://ci.appveyor.com/project/ruby/ruby/builds/29214253/job/r9u9c8p95tnlftt3#L24965

which is reported as a separate bug:

  https://bugs.ruby-lang.org/issues/16382?next_issue_id=16381

For now this commit should fix the builds, but we should come back and
add back the 'gem' call.

diff --git a/gem_prelude.rb b/gem_prelude.rb
index be9c419..1d0158d 100644
--- a/gem_prelude.rb
+++ b/gem_prelude.rb
@@ -1,8 +1,2 @@ https://github.com/ruby/ruby/blob/trunk/gem_prelude.rb#L1
-if defined?(Gem)
-  require 'rubygems.rb'
-  begin
-    gem 'did_you_mean'
-    require 'did_you_mean'
-  rescue Gem::LoadError, LoadError
-  end if defined?(DidYouMean)
-end
+require 'rubygems.rb' if defined?(Gem)
+require 'did_you_mean' if defined?(DidYouMean)
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]