[前][次][番号順一覧][スレッド一覧]

ruby-changes:56811

From: Takashi <ko1@a...>
Date: Mon, 5 Aug 2019 09:17:17 +0900 (JST)
Subject: [ruby-changes:56811] Takashi Kokubun: 548cd6e2b5 (master): Drop default leaf definition and obsoleted comments

https://git.ruby-lang.org/ruby.git/commit/?id=548cd6e2b5

From 548cd6e2b51ee0ed7b59799950681d46a43c6c85 Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Mon, 5 Aug 2019 09:16:12 +0900
Subject: Drop default leaf definition and obsoleted comments

leaf is true by default. Other insns are not specifying it explicitly.
Also the comment describing why it was not leaf is outdated.

diff --git a/insns.def b/insns.def
index e91382d..40855d6 100644
--- a/insns.def
+++ b/insns.def
@@ -1158,10 +1158,6 @@ opt_eq https://github.com/ruby/ruby/blob/trunk/insns.def#L1158
 (CALL_INFO ci, CALL_CACHE cc)
 (VALUE recv, VALUE obj)
 (VALUE val)
-/* This instruction can compare a string with non-string.  This
- * (somewhat) coerces the non-string into a string, via a method
- * call. */
-// attr bool leaf = true;
 {
     val = opt_eq_func(recv, obj, ci, cc);
 
@@ -1176,8 +1172,6 @@ opt_neq https://github.com/ruby/ruby/blob/trunk/insns.def#L1172
 (CALL_INFO ci_eq, CALL_CACHE cc_eq, CALL_INFO ci, CALL_CACHE cc)
 (VALUE recv, VALUE obj)
 (VALUE val)
-/* Same discussion as opt_eq. */
-// attr bool leaf = true;
 {
     val = vm_opt_neq(ci, cc, ci_eq, cc_eq, recv, obj);
 
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]