ruby-changes:55735
From: Takashi <ko1@a...>
Date: Thu, 16 May 2019 15:15:24 +0900 (JST)
Subject: [ruby-changes:55735] Takashi Kokubun: 82332c7d8b (trunk): Rename mjit_gc_finish_hook to mjit_gc_exit_hook
https://git.ruby-lang.org/ruby.git/commit/?id=82332c7d8b From 82332c7d8b17b610a347f7c804219c7fcb702d23 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun <takashikkbn@g...> Date: Wed, 15 May 2019 23:13:36 -0700 Subject: Rename mjit_gc_finish_hook to mjit_gc_exit_hook because @ko1 said "gc_finish" is confusing like a finish of entire GC process diff --git a/gc.c b/gc.c index 32e6c3d..afa194b 100644 --- a/gc.c +++ b/gc.c @@ -7140,7 +7140,7 @@ gc_exit(rb_objspace_t *objspace, const char *event) https://github.com/ruby/ruby/blob/trunk/gc.c#L7140 gc_report(1, objspace, "gc_exit: %s [%s]\n", event, gc_current_status(objspace)); during_gc = FALSE; - mjit_gc_finish_hook(); + mjit_gc_exit_hook(); } static void * diff --git a/mjit.c b/mjit.c index a4550e9..9142e92 100644 --- a/mjit.c +++ b/mjit.c @@ -99,15 +99,15 @@ mjit_gc_start_hook(void) https://github.com/ruby/ruby/blob/trunk/mjit.c#L99 // Send a signal to workers to continue iseq compilations. It is // called at the end of GC. void -mjit_gc_finish_hook(void) +mjit_gc_exit_hook(void) { if (!mjit_enabled) return; - CRITICAL_SECTION_START(4, "mjit_gc_finish_hook"); + CRITICAL_SECTION_START(4, "mjit_gc_exit_hook"); in_gc = false; verbose(4, "Sending wakeup signal to workers after GC"); rb_native_cond_broadcast(&mjit_gc_wakeup); - CRITICAL_SECTION_FINISH(4, "mjit_gc_finish_hook"); + CRITICAL_SECTION_FINISH(4, "mjit_gc_exit_hook"); } // Deal with ISeq movement from compactor diff --git a/mjit.h b/mjit.h index f50b364..6c6e800 100644 --- a/mjit.h +++ b/mjit.h @@ -82,7 +82,7 @@ extern void mjit_init(struct mjit_options *opts); https://github.com/ruby/ruby/blob/trunk/mjit.h#L82 extern void mjit_postponed_job_register_start_hook(void); extern void mjit_postponed_job_register_finish_hook(void); extern void mjit_gc_start_hook(void); -extern void mjit_gc_finish_hook(void); +extern void mjit_gc_exit_hook(void); extern void mjit_free_iseq(const rb_iseq_t *iseq); extern void mjit_update_references(const rb_iseq_t *iseq); extern void mjit_mark(void); @@ -167,7 +167,7 @@ static inline void mjit_cont_free(struct mjit_cont *cont){} https://github.com/ruby/ruby/blob/trunk/mjit.h#L167 static inline void mjit_postponed_job_register_start_hook(void){} static inline void mjit_postponed_job_register_finish_hook(void){} static inline void mjit_gc_start_hook(void){} -static inline void mjit_gc_finish_hook(void){} +static inline void mjit_gc_exit_hook(void){} static inline void mjit_free_iseq(const rb_iseq_t *iseq){} static inline void mjit_mark(void){} static inline void mjit_add_class_serial(rb_serial_t class_serial){} diff --git a/mjit_worker.c b/mjit_worker.c index 8b68cf0..4a7d47c 100644 --- a/mjit_worker.c +++ b/mjit_worker.c @@ -1052,7 +1052,7 @@ convert_unit_to_func(struct rb_mjit_unit *unit) https://github.com/ruby/ruby/blob/trunk/mjit_worker.c#L1052 // print #include of MJIT header, etc. compile_prelude(f); - // wait until mjit_gc_finish_hook is called + // wait until mjit_gc_exit_hook is called CRITICAL_SECTION_START(3, "before mjit_compile to wait GC finish"); while (in_gc) { verbose(3, "Waiting wakeup from GC"); -- cgit v0.10.2 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/