[前][次][番号順一覧][スレッド一覧]

ruby-changes:54520

From: nobu <ko1@a...>
Date: Sun, 6 Jan 2019 13:37:03 +0900 (JST)
Subject: [ruby-changes:54520] nobu:r66735 (trunk): Fix mday overflow

nobu	2019-01-06 13:36:56 +0900 (Sun, 06 Jan 2019)

  New Revision: 66735

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=66735

  Log:
    Fix mday overflow
    
    [ruby-core:90897] [Bug #15506]

  Modified files:
    trunk/lib/time.rb
    trunk/test/test_time.rb
Index: test/test_time.rb
===================================================================
--- test/test_time.rb	(revision 66734)
+++ test/test_time.rb	(revision 66735)
@@ -503,6 +503,10 @@ class TestTimeExtension < Test::Unit::Te https://github.com/ruby/ruby/blob/trunk/test/test_time.rb#L503
     assert_equal(0, t.hour)
     assert_equal(0, t.min)
     assert_equal(0, t.sec)
+    t = Time.strptime("2018-091", "%Y-%j")
+    assert_equal(2018, t.year)
+    assert_equal(4, t.mon)
+    assert_equal(1, t.day)
   end
 
   def test_nsec
Index: lib/time.rb
===================================================================
--- lib/time.rb	(revision 66734)
+++ lib/time.rb	(revision 66735)
@@ -201,6 +201,9 @@ class Time https://github.com/ruby/ruby/blob/trunk/lib/time.rb#L201
       end
 
       if yday
+        unless (1..366) === yday
+          raise ArgumentError, "yday #{yday} out of range"
+        end
         mon, day = (yday-1).divmod(31)
         mon += 1
         day += 1
@@ -208,6 +211,12 @@ class Time https://github.com/ruby/ruby/blob/trunk/lib/time.rb#L211
         diff = yday - t.yday
         return t if diff.zero?
         day += diff
+        if day > 28 and day > (mday = month_days(off_year, mon))
+          if (mon += 1) > 12
+            raise ArgumentError, "yday #{yday} out of range"
+          end
+          day -= mday
+        end
         return make_time(date, year, nil, mon, day, hour, min, sec, sec_fraction, zone, now)
       end
 
@@ -433,7 +442,7 @@ class Time https://github.com/ruby/ruby/blob/trunk/lib/time.rb#L442
     #
     def strptime(date, format, now=self.now)
       d = Date._strptime(date, format)
-      raise ArgumentError, "invalid strptime format - `#{format}'" unless d
+      raise ArgumentError, "invalid date or strptime format - `#{date}' `#{format}'" unless d
       if seconds = d[:seconds]
         if sec_fraction = d[:sec_fraction]
           usec = sec_fraction * 1000000

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]