[前][次][番号順一覧][スレッド一覧]

ruby-changes:53355

From: k0kubun <ko1@a...>
Date: Tue, 6 Nov 2018 16:30:41 +0900 (JST)
Subject: [ruby-changes:53355] k0kubun:r65571 (trunk): mjit_worker.c: don't use _one for now

k0kubun	2018-11-06 16:30:37 +0900 (Tue, 06 Nov 2018)

  New Revision: 65571

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=65571

  Log:
    mjit_worker.c: don't use _one for now
    
    I'm planning to use _one later, but it may be doubly registered by
    switching `stop_worker_p` now and so we should not use _one for now.
    
    Otherwise stale job may reject new job registration and
    copy_cache_from_main_thread may wait forever.

  Modified files:
    trunk/mjit_worker.c
Index: mjit_worker.c
===================================================================
--- mjit_worker.c	(revision 65570)
+++ mjit_worker.c	(revision 65571)
@@ -1145,7 +1145,7 @@ copy_cache_from_main_thread(struct mjit_ https://github.com/ruby/ruby/blob/trunk/mjit_worker.c#L1145
         return job->finish_p;
     }
 
-    if (!rb_postponed_job_register_one(0, mjit_copy_job_handler, (void *)job))
+    if (!rb_postponed_job_register(0, mjit_copy_job_handler, (void *)job))
         return FALSE;
     CRITICAL_SECTION_START(3, "in MJIT copy job wait");
     /* checking `stop_worker_p` too because `RUBY_VM_CHECK_INTS(ec)` may not

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]