ruby-changes:52780
From: k0kubun <ko1@a...>
Date: Wed, 10 Oct 2018 20:39:53 +0900 (JST)
Subject: [ruby-changes:52780] k0kubun:r64992 (trunk): spec: add comments to re-enable specs for MinGW [ci skip]
k0kubun 2018-10-10 20:39:46 +0900 (Wed, 10 Oct 2018) New Revision: 64992 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=64992 Log: spec: add comments to re-enable specs for MinGW [ci skip] r64918 and r64988 should not be kept forever. Modified files: trunk/spec/ruby/core/thread/terminate_spec.rb trunk/spec/ruby/core/threadgroup/add_spec.rb Index: spec/ruby/core/thread/terminate_spec.rb =================================================================== --- spec/ruby/core/thread/terminate_spec.rb (revision 64991) +++ spec/ruby/core/thread/terminate_spec.rb (revision 64992) @@ -3,6 +3,8 @@ require_relative 'fixtures/classes' https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/thread/terminate_spec.rb#L3 require_relative 'shared/exit' describe "Thread#terminate" do + # This spec randomly kills mspec worker like: https://ci.appveyor.com/project/ruby/ruby/builds/19390874/job/wv1bsm8skd4e1pxl + # TODO: Investigate the cause or at least print helpful logs, and remove this `platform_is_not` guard. platform_is_not :mingw do it_behaves_like :thread_exit, :terminate end Index: spec/ruby/core/threadgroup/add_spec.rb =================================================================== --- spec/ruby/core/threadgroup/add_spec.rb (revision 64991) +++ spec/ruby/core/threadgroup/add_spec.rb (revision 64992) @@ -13,6 +13,8 @@ describe "ThreadGroup#add" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/threadgroup/add_spec.rb#L13 @thread.join end + # This spec randomly kills mspec worker like: https://ci.appveyor.com/project/ruby/ruby/build/9806/job/37tx2atojy96227m + # TODO: Investigate the cause or at least print helpful logs, and remove this `platform_is_not` guard. platform_is_not :mingw do it "adds the given thread to a group and returns self" do @thread.group.should_not == nil -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/