[前][次][番号順一覧][スレッド一覧]

ruby-changes:52731

From: k0kubun <ko1@a...>
Date: Sun, 7 Oct 2018 23:06:02 +0900 (JST)
Subject: [ruby-changes:52731] k0kubun:r64943 (trunk): appveyor.yml: give up running TestThreadQueue#test_queue_with_trap

k0kubun	2018-10-07 23:05:56 +0900 (Sun, 07 Oct 2018)

  New Revision: 64943

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=64943

  Log:
    appveyor.yml: give up running TestThreadQueue#test_queue_with_trap
    
    for mswin. We tried to increase timeout and execute separately but both
    didn't work. Let me skip this until somebody starts to work on fixing
    this behavior, since this makes AppVeyor almost impossible to be used as CI.

  Removed files:
    trunk/test/excludes/TestThreadQueue.rb
  Modified files:
    trunk/appveyor.yml
    trunk/test/ruby/test_thread_queue.rb
Index: test/excludes/TestThreadQueue.rb
===================================================================
--- test/excludes/TestThreadQueue.rb	(revision 64942)
+++ test/excludes/TestThreadQueue.rb	(nonexistent)
@@ -1,12 +0,0 @@ https://github.com/ruby/ruby/blob/trunk/test/excludes/TestThreadQueue.rb#L0
-if ENV['APPVEYOR'] == 'True' && RUBY_PLATFORM.match?(/mswin/)
-  exclude :test_queue_with_trap, 'too unstable on vs140'
-  # separately tested on appveyor.yml.
-end
-
-# https://ci.appveyor.com/project/ruby/ruby/build/9795/job/l9t4w9ks7arsldb1
-#   1) Error:
-# TestThreadQueue#test_queue_with_trap:
-# Timeout::Error: execution of assert_in_out_err expired timeout (30.0 sec)
-# pid 22988 exit 0
-# |
-#     C:/projects/ruby/test/ruby/test_thread_queue.rb:553:in `test_queue_with_trap'

Property changes on: test/excludes/TestThreadQueue.rb
___________________________________________________________________
Deleted: svn:eol-style
## -1 +0,0 ##
-LF
\ No newline at end of property
Index: test/ruby/test_thread_queue.rb
===================================================================
--- test/ruby/test_thread_queue.rb	(revision 64942)
+++ test/ruby/test_thread_queue.rb	(revision 64943)
@@ -550,6 +550,9 @@ class TestThreadQueue < Test::Unit::Test https://github.com/ruby/ruby/blob/trunk/test/ruby/test_thread_queue.rb#L550
   end
 
   def test_queue_with_trap
+    if ENV['APPVEYOR'] == 'True' && RUBY_PLATFORM.match?(/mswin/)
+      skip 'This test fails too often on AppVeyor vs140'
+    end
     assert_in_out_err([], <<-INPUT, %w(INT INT exit), [])
       q = Queue.new
       trap(:INT){
Index: appveyor.yml
===================================================================
--- appveyor.yml	(revision 64942)
+++ appveyor.yml	(revision 64943)
@@ -93,8 +93,8 @@ for: https://github.com/ruby/ruby/blob/trunk/appveyor.yml#L93
     - nmake -l "TESTOPTS=-v -q" btest
     - nmake -l "TESTOPTS=-v -q" test-basic
     - nmake -l "TESTOPTS=-q -j%JOBS% --subprocess-timeout-scale=1.5" test-all RUBY_FORCE_TEST_JIT=1
-    # execute unstable tests separately without -j.
-    - nmake -l "TESTOPTS=-q --subprocess-timeout-scale=3.0" test-all TEST_EXCLUDES= TESTS="../test/win32ole/test_win32ole.rb ../test/ruby/test_thread_queue.rb"
+    # separately execute tests that may crash worker without -j.
+    - nmake -l "TESTOPTS=-q --subprocess-timeout-scale=1.5" test-all TEST_EXCLUDES= TESTS="../test/win32ole/test_win32ole.rb"
     - nmake -l test-spec
 -
   matrix:

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]