nobu	2018-07-18 19:30:41 +0900 (Wed, 18 Jul 2018)

  New Revision: 63994

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=63994

  Log:
    reduce tzset
    
    * time.c (rb_localtime_r): call tzset() only after TZ environment
      variable is changed.

  Modified files:
    trunk/hash.c
    trunk/time.c
Index: hash.c
===================================================================
--- hash.c	(revision 63993)
+++ hash.c	(revision 63994)
@@ -3315,6 +3315,9 @@ env_str_new2(const char *ptr) https://github.com/ruby/ruby/blob/trunk/hash.c#L3315
 
 static int env_path_tainted(const char *);
 
+static const char TZ_ENV[] = "TZ";
+extern int ruby_tz_update;
+
 static rb_encoding *
 env_encoding_for(const char *name, const char *ptr)
 {
@@ -3396,6 +3399,9 @@ env_delete(VALUE obj, VALUE name) https://github.com/ruby/ruby/blob/trunk/hash.c#L3399
 	    RB_GC_GUARD(name);
 	    path_tainted = 0;
 	}
+	else if (ENVMATCH(nam, TZ_ENV)) {
+	    ruby_tz_update = 0;
+	}
 	return value;
     }
     return Qnil;
@@ -3755,6 +3761,9 @@ env_aset(VALUE obj, VALUE nm, VALUE val) https://github.com/ruby/ruby/blob/trunk/hash.c#L3761
 	    path_tainted_p(value);
 	}
     }
+    else if (ENVMATCH(name, TZ_ENV)) {
+	ruby_tz_update = 0;
+    }
     return val;
 }
 
Index: time.c
===================================================================
--- time.c	(revision 63993)
+++ time.c	(revision 63994)
@@ -647,12 +647,18 @@ static struct vtm *localtimew(wideval_t https://github.com/ruby/ruby/blob/trunk/time.c#L647
 static int leap_year_p(long y);
 #define leap_year_v_p(y) leap_year_p(NUM2LONG(modv((y), INT2FIX(400))))
 
+int ruby_tz_update;
+
 static struct tm *
 rb_localtime_r(const time_t *t, struct tm *result)
 {
 #if defined __APPLE__ && defined __LP64__
     if (*t != (time_t)(int)*t) return NULL;
 #endif
+    if (!ruby_tz_update) {
+	ruby_tz_update = 1;
+	tzset();
+    }
 #ifdef HAVE_GMTIME_R
     result = localtime_r(t, result);
 #else
@@ -678,7 +684,7 @@ rb_localtime_r(const time_t *t, struct t https://github.com/ruby/ruby/blob/trunk/time.c#L684
 #endif
     return result;
 }
-#define LOCALTIME(tm, result) (tzset(),rb_localtime_r((tm), &(result)))
+#define LOCALTIME(tm, result) rb_localtime_r((tm), &(result))
 
 #ifndef HAVE_STRUCT_TM_TM_GMTOFF
 static struct tm *

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/