[前][次][番号順一覧][スレッド一覧]

ruby-changes:51558

From: eregon <ko1@a...>
Date: Thu, 28 Jun 2018 13:54:59 +0900 (JST)
Subject: [ruby-changes:51558] eregon:r63767 (trunk): Update to ruby/spec@41068a6

eregon	2018-06-27 20:37:31 +0900 (Wed, 27 Jun 2018)

  New Revision: 63767

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=63767

  Log:
    Update to ruby/spec@41068a6
    
    * Only small fixes to specs from CRuby to review the diff more easily.

  Modified files:
    trunk/spec/ruby/language/constants_spec.rb
    trunk/spec/ruby/language/precedence_spec.rb
    trunk/spec/ruby/library/etc/getgrgid_spec.rb
Index: spec/ruby/language/precedence_spec.rb
===================================================================
--- spec/ruby/language/precedence_spec.rb	(revision 63766)
+++ spec/ruby/language/precedence_spec.rb	(revision 63767)
@@ -301,13 +301,9 @@ describe "Operators" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/language/precedence_spec.rb#L301
    from = 1
    to = 2
    # These are Range instances, not flip-flop
-   @verbose = $VERBOSE
-   $VERBOSE = nil
-   begin
+   suppress_warning do
      (eval("from..to") ? 3 : 4).should == 3
      (eval("from...to") ? 3 : 4).should == 3
-   ensure
-     $VERBOSE = @verbose
    end
  end
 
Index: spec/ruby/language/constants_spec.rb
===================================================================
--- spec/ruby/language/constants_spec.rb	(revision 63766)
+++ spec/ruby/language/constants_spec.rb	(revision 63767)
@@ -643,7 +643,9 @@ describe "Module#private_constant marked https://github.com/ruby/ruby/blob/trunk/spec/ruby/language/constants_spec.rb#L643
       lambda do
         ConstantVisibility::PrivConstModuleChild::PRIVATE_CONSTANT_MODULE
       end.should raise_error(NameError) {|e|
-        e.receiver.should == ConstantVisibility::PrivConstModule
+        ruby_bug "#14853", ""..."2.5.2" do
+          e.receiver.should == ConstantVisibility::PrivConstModule
+        end
         e.name.should == :PRIVATE_CONSTANT_MODULE
       }
     end
Index: spec/ruby/library/etc/getgrgid_spec.rb
===================================================================
--- spec/ruby/library/etc/getgrgid_spec.rb	(revision 63766)
+++ spec/ruby/library/etc/getgrgid_spec.rb	(revision 63767)
@@ -13,62 +13,64 @@ end https://github.com/ruby/ruby/blob/trunk/spec/ruby/library/etc/getgrgid_spec.rb#L13
 
 # TODO: verify these on non-windows, non-darwin OS
 platform_is_not :windows do
-  grpname = IO.popen(%w'id -gn', err: IO::NULL, &:read)
-  next unless $?.success?
-  grpname.chomp!
-
-  describe "Etc.getgrgid" do
-    before :all do
-      @gid = `id -g`.strip.to_i
-      @name = grpname
-    end
-
-    it "returns a Etc::Group struct instance for the given user" do
-      gr = Etc.getgrgid(@gid)
-
-      gr.is_a?(Etc::Group).should == true
-      gr.gid.should == @gid
-      gr.name.should == @name
-    end
-
-    it "returns the Etc::Group for a given gid if it exists" do
-      grp = Etc.getgrgid(@gid)
-      grp.should be_kind_of(Etc::Group)
-      grp.gid.should == @gid
-      grp.name.should == @name
-    end
-
-    it "uses Process.gid as the default value for the argument" do
-      gr = Etc.getgrgid
-
-      gr.gid.should == @gid
-      gr.name.should == @name
-    end
-
-    it "returns the Group for a given gid if it exists" do
-      grp = Etc.getgrgid(@gid)
-      grp.should be_kind_of(Struct::Group)
-      grp.gid.should == @gid
-      grp.name.should == @name
-    end
-
-    it "raises if the group does not exist" do
-      lambda { Etc.getgrgid(9876)}.should raise_error(ArgumentError)
-    end
-
-    it "raises a TypeError if not passed an Integer" do
-      lambda { Etc.getgrgid("foo") }.should raise_error(TypeError)
-      lambda { Etc.getgrgid(nil)   }.should raise_error(TypeError)
-    end
-
-    it "can be called safely by multiple threads" do
-      20.times.map do
-        Thread.new do
-          100.times do
-            Etc.getgrgid(@gid).gid.should == @gid
+  grpname = nil
+  guard -> {
+    grpname = IO.popen(%w'id -gn', err: IO::NULL, &:read).chomp
+    $?.success?
+  } do
+    describe "Etc.getgrgid" do
+      before :all do
+        @gid = `id -g`.strip.to_i
+        @name = grpname
+      end
+
+      it "returns a Etc::Group struct instance for the given user" do
+        gr = Etc.getgrgid(@gid)
+
+        gr.is_a?(Etc::Group).should == true
+        gr.gid.should == @gid
+        gr.name.should == @name
+      end
+
+      it "returns the Etc::Group for a given gid if it exists" do
+        grp = Etc.getgrgid(@gid)
+        grp.should be_kind_of(Etc::Group)
+        grp.gid.should == @gid
+        grp.name.should == @name
+      end
+
+      it "uses Process.gid as the default value for the argument" do
+        gr = Etc.getgrgid
+
+        gr.gid.should == @gid
+        gr.name.should == @name
+      end
+
+      it "returns the Group for a given gid if it exists" do
+        grp = Etc.getgrgid(@gid)
+        grp.should be_kind_of(Struct::Group)
+        grp.gid.should == @gid
+        grp.name.should == @name
+      end
+
+      it "raises if the group does not exist" do
+        lambda { Etc.getgrgid(9876)}.should raise_error(ArgumentError)
+      end
+
+      it "raises a TypeError if not passed an Integer" do
+        lambda { Etc.getgrgid("foo") }.should raise_error(TypeError)
+        lambda { Etc.getgrgid(nil)   }.should raise_error(TypeError)
+      end
+
+      it "can be called safely by multiple threads" do
+        20.times.map do
+          Thread.new do
+            100.times do
+              Etc.getgrgid(@gid).gid.should == @gid
+            end
           end
-        end
-      end.each(&:join)
+        end.each(&:join)
+      end
     end
   end
 end

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]