nobu	2018-04-30 11:17:03 +0900 (Mon, 30 Apr 2018)

  New Revision: 63304

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=63304

  Log:
    io.c: workaround for EPROTOTYPE
    
    * io.c (internal_write_func, internal_writev_func): retry at
      unexpected EPROTOTYPE on macOS, to get rid of a kernel bug.
      [ruby-core:86690] [Bug #14713]
    
    * ext/socket/init.c (rsock_{sendto,send,write}_blocking): ditto.

  Modified files:
    trunk/ext/socket/init.c
    trunk/io.c
    trunk/test/net/ftp/test_ftp.rb
    trunk/test/webrick/test_httpserver.rb
Index: io.c
===================================================================
--- io.c	(revision 63303)
+++ io.c	(revision 63304)
@@ -945,11 +945,18 @@ internal_read_func(void *ptr) https://github.com/ruby/ruby/blob/trunk/io.c#L945
     return read(iis->fd, iis->buf, iis->capa);
 }
 
+#if defined __APPLE__
+# define do_write_retry(code) do {ret = code;} while (ret == -1 && errno == EPROTOTYPE)
+#else
+# define do_write_retry(code) ret = code
+#endif
 static VALUE
 internal_write_func(void *ptr)
 {
     struct io_internal_write_struct *iis = ptr;
-    return write(iis->fd, iis->buf, iis->capa);
+    ssize_t ret;
+    do_write_retry(write(iis->fd, iis->buf, iis->capa));
+    return (VALUE)ret;
 }
 
 static void*
@@ -963,7 +970,9 @@ static VALUE https://github.com/ruby/ruby/blob/trunk/io.c#L970
 internal_writev_func(void *ptr)
 {
     struct io_internal_writev_struct *iis = ptr;
-    return writev(iis->fd, iis->iov, iis->iovcnt);
+    ssize_t ret;
+    do_write_retry(writev(iis->fd, iis->iov, iis->iovcnt));
+    return (VALUE)ret;
 }
 #endif
 
Index: ext/socket/init.c
===================================================================
--- ext/socket/init.c	(revision 63303)
+++ ext/socket/init.c	(revision 63304)
@@ -68,6 +68,12 @@ is_socket(int fd) https://github.com/ruby/ruby/blob/trunk/ext/socket/init.c#L68
 }
 #endif
 
+#if defined __APPLE__
+# define do_write_retry(code) do {ret = code;} while (ret == -1 && errno == EPROTOTYPE)
+#else
+# define do_write_retry(code) ret = code
+#endif
+
 VALUE
 rsock_init_sock(VALUE sock, int fd)
 {
@@ -95,8 +101,10 @@ rsock_sendto_blocking(void *data) https://github.com/ruby/ruby/blob/trunk/ext/socket/init.c#L101
 {
     struct rsock_send_arg *arg = data;
     VALUE mesg = arg->mesg;
-    return (VALUE)sendto(arg->fd, RSTRING_PTR(mesg), RSTRING_LEN(mesg),
-                         arg->flags, arg->to, arg->tolen);
+    ssize_t ret;
+    do_write_retry(sendto(arg->fd, RSTRING_PTR(mesg), RSTRING_LEN(mesg),
+			  arg->flags, arg->to, arg->tolen));
+    return (VALUE)ret;
 }
 
 VALUE
@@ -104,8 +112,10 @@ rsock_send_blocking(void *data) https://github.com/ruby/ruby/blob/trunk/ext/socket/init.c#L112
 {
     struct rsock_send_arg *arg = data;
     VALUE mesg = arg->mesg;
-    return (VALUE)send(arg->fd, RSTRING_PTR(mesg), RSTRING_LEN(mesg),
-                       arg->flags);
+    ssize_t ret;
+    do_write_retry(send(arg->fd, RSTRING_PTR(mesg), RSTRING_LEN(mesg),
+			arg->flags));
+    return (VALUE)ret;
 }
 
 struct recvfrom_arg {
@@ -378,10 +388,18 @@ rsock_write_nonblock(VALUE sock, VALUE s https://github.com/ruby/ruby/blob/trunk/ext/socket/init.c#L388
 	rb_io_flush(sock);
     }
 
+#ifdef __APPLE__
+  again:
+#endif
     n = (long)send(fptr->fd, RSTRING_PTR(str), RSTRING_LEN(str), MSG_DONTWAIT);
     if (n < 0) {
 	int e = errno;
 
+#ifdef __APPLE__
+	if (e == EPROTOTYPE) {
+	    goto again;
+	}
+#endif
 	if (e == EWOULDBLOCK || e == EAGAIN) {
 	    if (ex == Qfalse) return sym_wait_writable;
 	    rb_readwrite_syserr_fail(RB_IO_WAIT_WRITABLE, e,
Index: test/webrick/test_httpserver.rb
===================================================================
--- test/webrick/test_httpserver.rb	(revision 63303)
+++ test/webrick/test_httpserver.rb	(revision 63304)
@@ -452,7 +452,7 @@ class TestWEBrickHTTPServer < Test::Unit https://github.com/ruby/ruby/blob/trunk/test/webrick/test_httpserver.rb#L452
       TCPSocket.open(addr, port) do |c|
         c.write("GET / HTTP/1.0\r\n")
         junk = -"X-Junk: #{' ' * 1024}\r\n"
-        assert_raise(Errno::ECONNRESET, Errno::EPIPE, Errno::EPROTOTYPE) do
+        assert_raise(Errno::ECONNRESET, Errno::EPIPE) do
           loop { c.write(junk) }
         end
       end
Index: test/net/ftp/test_ftp.rb
===================================================================
--- test/net/ftp/test_ftp.rb	(revision 63303)
+++ test/net/ftp/test_ftp.rb	(revision 63304)
@@ -425,7 +425,7 @@ class FTPTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L425
           end
           conn.print(l, "\r\n")
         end
-      rescue Errno::EPIPE, Errno::EPROTOTYPE
+      rescue Errno::EPIPE
       ensure
         assert_nil($!)
         conn.close

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/