ruby-changes:49405
From: ko1 <ko1@a...>
Date: Sun, 31 Dec 2017 09:06:43 +0900 (JST)
Subject: [ruby-changes:49405] ko1:r61521 (trunk): fix reset order.
ko1 2017-12-31 09:06:34 +0900 (Sun, 31 Dec 2017) New Revision: 61521 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=61521 Log: fix reset order. * lib/rdoc/test_case.rb (setup): call `RDoc::Markup::PreProcess.reset` at the end of `setup` method. `RDoc::RDoc.new` requires `rdoc/generator/darkfish` and requires `rdoc/tom_doc.rb` at last. It add post_proecssor (at `add_post_processor`) and it fails `TestRDocMarkupPreProcess#test_class_post_process`. This issue occured only with sorted tests by alphabetical order. `make test-all TESTS='rdoc/test_rdoc_markup_pre_process.rb --test-order=alpha`) We can observe this failure with parallel test only a few times. Modified files: trunk/lib/rdoc/test_case.rb Index: lib/rdoc/test_case.rb =================================================================== --- lib/rdoc/test_case.rb (revision 61520) +++ lib/rdoc/test_case.rb (revision 61521) @@ -41,8 +41,6 @@ class RDoc::TestCase < MiniTest::Unit::T https://github.com/ruby/ruby/blob/trunk/lib/rdoc/test_case.rb#L41 @RM = RDoc::Markup - RDoc::Markup::PreProcess.reset - @pwd = Dir.pwd @store = RDoc::Store.new @@ -55,6 +53,8 @@ class RDoc::TestCase < MiniTest::Unit::T https://github.com/ruby/ruby/blob/trunk/lib/rdoc/test_case.rb#L53 def g.class_dir() end def g.file_dir() end @rdoc.generator = g + + RDoc::Markup::PreProcess.reset end ## -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/