glass	2017-10-02 16:51:27 +0900 (Mon, 02 Oct 2017)

  New Revision: 60098

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=60098

  Log:
    Revert "vm_eval.c: add rb_yield_assoc_or_values()"
    
    This reverts commit r60095 to prevent performance degradation.

  Modified files:
    trunk/hash.c
    trunk/internal.h
    trunk/struct.c
    trunk/vm_eval.c
Index: internal.h
===================================================================
--- internal.h	(revision 60097)
+++ internal.h	(revision 60098)
@@ -1768,7 +1768,6 @@ VALUE rb_check_funcall_with_hook(VALUE r https://github.com/ruby/ruby/blob/trunk/internal.h#L1768
 VALUE rb_check_funcall_default(VALUE, ID, int, const VALUE *, VALUE);
 VALUE rb_yield_1(VALUE val);
 VALUE rb_yield_force_blockarg(VALUE values);
-VALUE rb_yield_assoc_or_values(VALUE key, VALUE value);
 VALUE rb_lambda_call(VALUE obj, ID mid, int argc, const VALUE *argv,
 		     rb_block_call_func_t bl_proc, int min_argc, int max_argc,
 		     VALUE data2);
Index: struct.c
===================================================================
--- struct.c	(revision 60097)
+++ struct.c	(revision 60098)
@@ -686,10 +686,19 @@ rb_struct_each_pair(VALUE s) https://github.com/ruby/ruby/blob/trunk/struct.c#L686
 
     RETURN_SIZED_ENUMERATOR(s, 0, 0, struct_enum_size);
     members = rb_struct_members(s);
-    for (i=0; i<RSTRUCT_LEN(s); i++) {
-	VALUE key = rb_ary_entry(members, i);
-	VALUE value = RSTRUCT_GET(s, i);
-	rb_yield_assoc_or_values(key, value);
+    if (rb_block_arity() > 1) {
+	for (i=0; i<RSTRUCT_LEN(s); i++) {
+	    VALUE key = rb_ary_entry(members, i);
+	    VALUE value = RSTRUCT_GET(s, i);
+	    rb_yield_values(2, key, value);
+	}
+    }
+    else {
+	for (i=0; i<RSTRUCT_LEN(s); i++) {
+	    VALUE key = rb_ary_entry(members, i);
+	    VALUE value = RSTRUCT_GET(s, i);
+	    rb_yield(rb_assoc_new(key, value));
+	}
     }
     return s;
 }
Index: hash.c
===================================================================
--- hash.c	(revision 60097)
+++ hash.c	(revision 60098)
@@ -1775,7 +1775,17 @@ rb_hash_each_key(VALUE hash) https://github.com/ruby/ruby/blob/trunk/hash.c#L1775
 static int
 each_pair_i(VALUE key, VALUE value)
 {
-    rb_yield_assoc_or_values(key, value);
+    rb_yield(rb_assoc_new(key, value));
+    return ST_CONTINUE;
+}
+
+static int
+each_pair_i_fast(VALUE key, VALUE value)
+{
+    VALUE argv[2];
+    argv[0] = key;
+    argv[1] = value;
+    rb_yield_values2(2, argv);
     return ST_CONTINUE;
 }
 
@@ -1805,7 +1815,10 @@ static VALUE https://github.com/ruby/ruby/blob/trunk/hash.c#L1815
 rb_hash_each_pair(VALUE hash)
 {
     RETURN_SIZED_ENUMERATOR(hash, 0, 0, hash_enum_size);
-    rb_hash_foreach(hash, each_pair_i, 0);
+    if (rb_block_arity() > 1)
+	rb_hash_foreach(hash, each_pair_i_fast, 0);
+    else
+	rb_hash_foreach(hash, each_pair_i, 0);
     return hash;
 }
 
@@ -2896,7 +2909,18 @@ rb_init_identtable_with_size(st_index_t https://github.com/ruby/ruby/blob/trunk/hash.c#L2909
 static int
 any_p_i(VALUE key, VALUE value, VALUE arg)
 {
-    VALUE ret = rb_yield_assoc_or_values(key, value);
+    VALUE ret = rb_yield(rb_assoc_new(key, value));
+    if (RTEST(ret)) {
+	*(VALUE *)arg = Qtrue;
+	return ST_STOP;
+    }
+    return ST_CONTINUE;
+}
+
+static int
+any_p_i_fast(VALUE key, VALUE value, VALUE arg)
+{
+    VALUE ret = rb_yield_values(2, key, value);
     if (RTEST(ret)) {
 	*(VALUE *)arg = Qtrue;
 	return ST_STOP;
@@ -2921,7 +2945,10 @@ rb_hash_any_p(VALUE hash) https://github.com/ruby/ruby/blob/trunk/hash.c#L2945
 	/* yields pairs, never false */
 	return Qtrue;
     }
-    rb_hash_foreach(hash, any_p_i, (VALUE)&ret);
+    if (rb_block_arity() > 1)
+	rb_hash_foreach(hash, any_p_i_fast, (VALUE)&ret);
+    else
+	rb_hash_foreach(hash, any_p_i, (VALUE)&ret);
     return ret;
 }
 
@@ -3767,8 +3794,15 @@ env_each_pair(VALUE ehash) https://github.com/ruby/ruby/blob/trunk/hash.c#L3794
     }
     FREE_ENVIRON(environ);
 
-    for (i=0; i<RARRAY_LEN(ary); i+=2) {
-	rb_yield_assoc_or_values(RARRAY_AREF(ary, i), RARRAY_AREF(ary, i+1));
+    if (rb_block_arity() > 1) {
+	for (i=0; i<RARRAY_LEN(ary); i+=2) {
+	    rb_yield_values(2, RARRAY_AREF(ary, i), RARRAY_AREF(ary, i+1));
+	}
+    }
+    else {
+	for (i=0; i<RARRAY_LEN(ary); i+=2) {
+	    rb_yield(rb_assoc_new(RARRAY_AREF(ary, i), RARRAY_AREF(ary, i+1)));
+	}
     }
     return ehash;
 }
Index: vm_eval.c
===================================================================
--- vm_eval.c	(revision 60097)
+++ vm_eval.c	(revision 60098)
@@ -1010,18 +1010,6 @@ rb_yield_values2(int argc, const VALUE * https://github.com/ruby/ruby/blob/trunk/vm_eval.c#L1010
 }
 
 VALUE
-rb_yield_assoc_or_values(VALUE key, VALUE value)
-{
-    if (rb_block_arity() > 1) {
-	VALUE argv[2] = { key, value };
-	return rb_yield_0(2, argv);
-    }
-    else {
-	return rb_yield_1(rb_assoc_new(key, value));
-    }
-}
-
-VALUE
 rb_yield_splat(VALUE values)
 {
     VALUE tmp = rb_check_array_type(values);

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/