ruby-changes:47859
From: eregon <ko1@a...>
Date: Thu, 21 Sep 2017 05:19:58 +0900 (JST)
Subject: [ruby-changes:47859] eregon:r59980 (trunk): Adapt tools to follow spec/rubyspec => spec/ruby rename
eregon 2017-09-21 05:19:54 +0900 (Thu, 21 Sep 2017) New Revision: 59980 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59980 Log: Adapt tools to follow spec/rubyspec => spec/ruby rename * [Misc #13792] [ruby-core:82287] * Prefer test-spec over test-rubyspec in spec/README. Modified files: trunk/.travis.yml trunk/LEGAL trunk/common.mk trunk/lib/net/ftp.rb trunk/spec/README.md trunk/spec/default.mspec trunk/tool/pull-latest-mspec-spec Index: tool/pull-latest-mspec-spec =================================================================== --- tool/pull-latest-mspec-spec (revision 59979) +++ tool/pull-latest-mspec-spec (revision 59980) @@ -10,9 +10,9 @@ rm -rf spec/mspec/.git https://github.com/ruby/ruby/blob/trunk/tool/pull-latest-mspec-spec#L10 git add spec/mspec git commit -m "Update to ruby/mspec@${commit}" -rm -rf spec/rubyspec -git clone --depth 1 https://github.com/ruby/spec.git spec/rubyspec -commit=$(git -C spec/rubyspec log -n 1 --format='%h') -rm -rf spec/rubyspec/.git -git add spec/rubyspec +rm -rf spec/ruby +git clone --depth 1 https://github.com/ruby/spec.git spec/ruby +commit=$(git -C spec/ruby log -n 1 --format='%h') +rm -rf spec/ruby/.git +git add spec/ruby git commit -m "Update to ruby/spec@${commit}" Index: common.mk =================================================================== --- common.mk (revision 59979) +++ common.mk (revision 59980) @@ -627,7 +627,7 @@ clean-platform: https://github.com/ruby/ruby/blob/trunk/common.mk#L627 $(Q) $(RM) $(PLATFORM_D) -$(Q) $(RMDIR) $(PLATFORM_DIR) 2> $(NULL) || exit 0 -RUBYSPEC_CAPIEXT = spec/rubyspec/optional/capi/ext +RUBYSPEC_CAPIEXT = spec/ruby/optional/capi/ext clean-spec: PHONY -$(Q) $(RM) $(RUBYSPEC_CAPIEXT)/*.$(OBJEXT) $(RUBYSPEC_CAPIEXT)/*.$(DLEXT) -$(Q) $(RMDIRS) $(RUBYSPEC_CAPIEXT) 2> $(NULL) || exit 0 Index: .travis.yml =================================================================== --- .travis.yml (revision 59979) +++ .travis.yml (revision 59980) @@ -45,8 +45,8 @@ before_script: https://github.com/ruby/ruby/blob/trunk/.travis.yml#L45 - "requests=; for req in ${RUBYSPEC_PULL_REQUEST//,/ }; do requests=\"$requests +refs/pull/$req/merge:\"; done" - - "${requests:+git -C spec/rubyspec -c user.email=none -c user.name=none pull --no-edit origin $requests}" - - "${requests:+git -C spec/rubyspec log --oneline origin/master..@}" + - "${requests:+git -C spec/ruby -c user.email=none -c user.name=none pull --no-edit origin $requests}" + - "${requests:+git -C spec/ruby log --oneline origin/master..@}" - "rm config.status Makefile rbconfig.rb .rbconfig.time" - "mkdir build config_1st config_2nd" - "chmod -R a-w ." @@ -62,7 +62,7 @@ before_script: https://github.com/ruby/ruby/blob/trunk/.travis.yml#L62 script: - "make -s test TESTOPTS=--color=never" - "make -s $JOBS test-all -o exts TESTOPTS='-q --color=never --job-status=normal'" - - "make -s $JOBS test-rubyspec MSPECOPT=-j" + - "make -s $JOBS test-spec MSPECOPT=-j" # Branch matrix. Not all branches are Travis-ready so we limit branches here. branches: Index: spec/README.md =================================================================== --- spec/README.md (revision 59979) +++ spec/README.md (revision 59980) @@ -9,16 +9,16 @@ To run rspec for bundler: https://github.com/ruby/ruby/blob/trunk/spec/README.md#L9 make test-bundler ``` -# spec/rubyspec +# spec/ruby ruby/spec (https://github.com/ruby/spec/) is a test suite for the Ruby language. -Once a month, @eregon merges the in-tree copy under spec/rubyspec +Once a month, @eregon merges the in-tree copy under spec/ruby with the upstream repository, preserving the commits and history. The same happens for other implementations such as JRuby and TruffleRuby. -Feel welcome to modify the in-tree spec/rubyspec. +Feel welcome to modify the in-tree spec/ruby. This is the purpose of the in-tree copy, to facilitate contributions to ruby/spec for MRI developers. @@ -34,36 +34,36 @@ Currently, the only module which is MRI- https://github.com/ruby/ruby/blob/trunk/spec/README.md#L34 To run all specs: ```bash -make test-rubyspec +make test-spec ``` Extra arguments can be added via `MSPECOPT`. For instance, to show the help: ```bash -make test-rubyspec MSPECOPT=-h +make test-spec MSPECOPT=-h ``` You can also run the specs in parallel, which is currently experimental. It takes around 10s instead of 60s on a quad-core laptop. ```bash -make test-rubyspec MSPECOPT=-j +make test-spec MSPECOPT=-j ``` To run a specific test, add its path to the command: ```bash -make test-rubyspec MSPECOPT=spec/rubyspec/language/for_spec.rb +make test-spec MSPECOPT=spec/ruby/language/for_spec.rb ``` If ruby trunk is your current `ruby` in `$PATH`, you can also run `mspec` directly: ```bash # change ruby to trunk ruby -v # => trunk -spec/mspec/bin/mspec spec/rubyspec/language/for_spec.rb +spec/mspec/bin/mspec spec/ruby/language/for_spec.rb ``` ## ruby/spec and test/ -The main difference between a "spec" under spec/rubyspec and +The main difference between a "spec" under spec/ruby and a test under test/ is that specs are documenting what they test. This is extremely valuable when reading these tests, as it helps to quickly understand what specific behavior is tested, @@ -87,4 +87,4 @@ describe "The for expression" do https://github.com/ruby/ruby/blob/trunk/spec/README.md#L87 end ``` -For more details, see spec/rubyspec/CONTRIBUTING.md. +For more details, see spec/ruby/CONTRIBUTING.md. Index: spec/default.mspec =================================================================== --- spec/default.mspec (revision 59979) +++ spec/default.mspec (revision 59980) @@ -4,8 +4,8 @@ if (opt = ENV["RUBYOPT"]) and (opt = opt https://github.com/ruby/ruby/blob/trunk/spec/default.mspec#L4 ENV["RUBYOPT"] = opt end require "./rbconfig" unless defined?(RbConfig) -load File.dirname(__FILE__) + '/rubyspec/default.mspec' -OBJDIR = File.expand_path("spec/rubyspec/optional/capi/ext") +load File.dirname(__FILE__) + '/ruby/default.mspec' +OBJDIR = File.expand_path("spec/ruby/optional/capi/ext") class MSpecScript builddir = Dir.pwd srcdir = ENV['SRCDIR'] @@ -19,7 +19,7 @@ class MSpecScript https://github.com/ruby/ruby/blob/trunk/spec/default.mspec#L19 # The default implementation to run the specs. set :target, File.join(builddir, "miniruby#{config['exeext']}") - set :prefix, File.expand_path('rubyspec', File.dirname(__FILE__)) + set :prefix, File.expand_path('ruby', File.dirname(__FILE__)) set :flags, %W[ -I#{srcdir}/lib #{srcdir}/tool/runruby.rb --archdir=#{Dir.pwd} --extout=#{config['EXTOUT']} Index: LEGAL =================================================================== --- LEGAL (revision 59979) +++ LEGAL (revision 59980) @@ -658,7 +658,7 @@ lib/rdoc/generator/template/darkfish/css https://github.com/ruby/ruby/blob/trunk/LEGAL#L658 http://scripts.sil.org/OFL spec/mspec: -spec/rubyspec: +spec/ruby: Copyright (c) 2008 Engine Yard, Inc. All rights reserved. Index: lib/net/ftp.rb =================================================================== --- lib/net/ftp.rb (revision 59979) +++ lib/net/ftp.rb (revision 59980) @@ -265,7 +265,7 @@ module Net https://github.com/ruby/ruby/blob/trunk/lib/net/ftp.rb#L265 if options[:port] connect(host, options[:port] || FTP_PORT) else - # spec/rubyspec/library/net/ftp/initialize_spec.rb depends on + # spec/ruby/library/net/ftp/initialize_spec.rb depends on # the number of arguments passed to connect.... connect(host) end -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/