nagachika	2017-05-09 23:55:29 +0900 (Tue, 09 May 2017)

  New Revision: 58630

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=58630

  Log:
    merge revision(s) 57265,57266: [Backport #13081]
    
    win32/resolv.rb: ad hoc workaround
    
    * ext/win32/lib/win32/resolv.rb (Win32::Resolv::SZ): an ad hoc
      workaround for broken registry.  SearchList and other registry
      values must be REG_SZ, or Windows ignores anything in those
      values otherwise.  [ruby-dev:49924] [Bug #13081]
      https://github.com/rubygems/rubygems/issues/1700
    win32/registry.rb: registry type names
    
    * ext/win32/lib/win32/registry.rb (Win32::Registry#read): show
      registry type names instead of numeric values.

  Modified directories:
    branches/ruby_2_4/
  Modified files:
    branches/ruby_2_4/ext/win32/lib/win32/registry.rb
    branches/ruby_2_4/ext/win32/lib/win32/resolv.rb
    branches/ruby_2_4/version.h
Index: ruby_2_4/ext/win32/lib/win32/registry.rb
===================================================================
--- ruby_2_4/ext/win32/lib/win32/registry.rb	(revision 58629)
+++ ruby_2_4/ext/win32/lib/win32/registry.rb	(revision 58630)
@@ -643,7 +643,9 @@ For detail, see the MSDN[http://msdn.mic https://github.com/ruby/ruby/blob/trunk/ruby_2_4/ext/win32/lib/win32/registry.rb#L643
     def read(name, *rtype)
       type, data = API.QueryValue(@hkey, name)
       unless rtype.empty? or rtype.include?(type)
-        raise TypeError, "Type mismatch (expect #{rtype.inspect} but #{type} present)"
+        raise TypeError, "Type mismatch (expect [#{
+          rtype.map{|t|Registry.type2name(t)}.join(', ')}] but #{
+          Registry.type2name(type)} present)"
       end
       case type
       when REG_SZ, REG_EXPAND_SZ
@@ -659,7 +661,7 @@ For detail, see the MSDN[http://msdn.mic https://github.com/ruby/ruby/blob/trunk/ruby_2_4/ext/win32/lib/win32/registry.rb#L661
       when REG_QWORD
         [ type, API.unpackqw(data) ]
       else
-        raise TypeError, "Type #{type} is not supported."
+        raise TypeError, "Type #{Registry.type2name(type)} is not supported."
       end
     end
 
@@ -682,7 +684,7 @@ For detail, see the MSDN[http://msdn.mic https://github.com/ruby/ruby/blob/trunk/ruby_2_4/ext/win32/lib/win32/registry.rb#L684
       when REG_EXPAND_SZ
         Registry.expand_environ(data)
       else
-        raise TypeError, "Type #{type} is not supported."
+        raise TypeError, "Type #{Registry.type2name(type)} is not supported."
       end
     end
 
@@ -755,7 +757,7 @@ For detail, see the MSDN[http://msdn.mic https://github.com/ruby/ruby/blob/trunk/ruby_2_4/ext/win32/lib/win32/registry.rb#L757
       when REG_QWORD
         data = API.packqw(data.to_i)
       else
-        raise TypeError, "Unsupported type #{type}"
+        raise TypeError, "Unsupported type #{Registry.type2name(type)}"
       end
       API.SetValue(@hkey, name, type, data, data.bytesize + termsize)
     end
Index: ruby_2_4/ext/win32/lib/win32/resolv.rb
===================================================================
--- ruby_2_4/ext/win32/lib/win32/resolv.rb	(revision 58629)
+++ ruby_2_4/ext/win32/lib/win32/resolv.rb	(revision 58630)
@@ -60,6 +60,21 @@ module Win32 https://github.com/ruby/ruby/blob/trunk/ruby_2_4/ext/win32/lib/win32/resolv.rb#L60
 # Windows NT
 #====================================================================
   module Resolv
+    module SZ
+      refine Registry do
+        # ad hoc workaround for broken registry
+        def read_s(key)
+          type, str = read(key)
+          unless type == Registry::REG_SZ
+            warn "Broken registry, #{name}\\#{key} was #{Registry.type2name(type)}, ignored"
+            return String.new
+          end
+          str
+        end
+      end
+    end
+    using SZ
+
     TCPIP_NT = 'SYSTEM\CurrentControlSet\Services\Tcpip\Parameters'
 
     class << self
Index: ruby_2_4/version.h
===================================================================
--- ruby_2_4/version.h	(revision 58629)
+++ ruby_2_4/version.h	(revision 58630)
@@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_4/version.h#L1
 #define RUBY_VERSION "2.4.2"
 #define RUBY_RELEASE_DATE "2017-05-09"
-#define RUBY_PATCHLEVEL 124
+#define RUBY_PATCHLEVEL 125
 
 #define RUBY_RELEASE_YEAR 2017
 #define RUBY_RELEASE_MONTH 5
Index: ruby_2_4
===================================================================
--- ruby_2_4	(revision 58629)
+++ ruby_2_4	(revision 58630)

Property changes on: ruby_2_4
___________________________________________________________________
Modified: svn:mergeinfo
## -0,0 +0,1 ##
   Merged /trunk:r57265-57266

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/