odaira	2016-04-28 05:00:57 +0900 (Thu, 28 Apr 2016)

  New Revision: 54803

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=54803

  Log:
    * configure.in (rb_cv_lgamma_r_pm0): check if lgamma_r(+0.0)
      returns positive infinity, in addition to lgamma_r(-0.0).
      AIX returns an incorrect result of negative infinity.
    
    * math.c (ruby_lgamma_r): handle +0.0, in addition to -0.0.

  Modified files:
    trunk/ChangeLog
    trunk/configure.in
    trunk/math.c
Index: math.c
===================================================================
--- math.c	(revision 54802)
+++ math.c	(revision 54803)
@@ -750,7 +750,7 @@ ruby_tgamma(const double d) https://github.com/ruby/ruby/blob/trunk/math.c#L750
 #define tgamma(d) ruby_tgamma(d)
 #endif
 
-#if defined LGAMMA_R_M0_FIX
+#if defined LGAMMA_R_PM0_FIX
 static inline double
 ruby_lgamma_r(const double d, int *sign)
 {
@@ -759,6 +759,9 @@ ruby_lgamma_r(const double d, int *sign) https://github.com/ruby/ruby/blob/trunk/math.c#L759
 	if (d == 0.0 && signbit(d)) {
 	    *sign = -1;
 	    return INFINITY;
+	} else if (d == 0.0 && !signbit(d)) {
+	    *sign = 1;
+	    return INFINITY;
 	}
     }
     return g;
Index: configure.in
===================================================================
--- configure.in	(revision 54802)
+++ configure.in	(revision 54803)
@@ -2503,7 +2503,7 @@ main(int argc, char **argv) https://github.com/ruby/ruby/blob/trunk/configure.in#L2503
 AS_IF([test "x$rb_cv_atan2_inf_c99" = xyes], [AC_DEFINE(ATAN2_INF_C99)])
 
 AS_IF([test "x$ac_cv_func_lgamma_r" = xyes], [
-    AC_CACHE_CHECK(whether lgamma_r handles -0.0, rb_cv_lgamma_r_m0, [
+    AC_CACHE_CHECK(whether lgamma_r handles +0.0 and -0.0, rb_cv_lgamma_r_pm0, [
 	AC_TRY_RUN([
 @%:@include <math.h>
 @%:@ifdef HAVE_UNISTD_H
@@ -2519,22 +2519,28 @@ AS_IF([test "x$ac_cv_func_lgamma_r" = xy https://github.com/ruby/ruby/blob/trunk/configure.in#L2519
 int
 main(int argc, char **argv)
 {
-    int sign;
+    int sign = 0;
     double x = lgamma_r(-0.0, &sign);
 
     /* should be [+inf, -1] */
     if (x <= 0) return EXIT_FAILURE;
     if (!isinf(x)) return EXIT_FAILURE;
     if (sign != -1) return EXIT_FAILURE;
+
+    /* should be [+inf, 1] */
+    x = lgamma_r(+0.0, &sign);
+    if (x <= 0) return EXIT_FAILURE;
+    if (!isinf(x)) return EXIT_FAILURE;
+    if (sign != 1) return EXIT_FAILURE;
     return EXIT_SUCCESS;
 }
 ],
-	[rb_cv_lgamma_r_m0=yes],
-	[rb_cv_lgamma_r_m0=no],
-	[rb_cv_lgamma_r_m0=yes]
+	[rb_cv_lgamma_r_pm0=yes],
+	[rb_cv_lgamma_r_pm0=no],
+	[rb_cv_lgamma_r_pm0=yes]
 	)
     ])
-    AS_IF([test "x$rb_cv_lgamma_r_m0" = xno], [AC_DEFINE(LGAMMA_R_M0_FIX)])
+    AS_IF([test "x$rb_cv_lgamma_r_pm0" = xno], [AC_DEFINE(LGAMMA_R_PM0_FIX)])
 ])
 
 # Some platform need -lrt for clock_gettime, but the other don't.
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 54802)
+++ ChangeLog	(revision 54803)
@@ -1,3 +1,11 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Thu Apr 28 04:49:07 2016  Rei Odaira  <Rei.Odaira@g...>
+
+	* configure.in (rb_cv_lgamma_r_pm0): check if lgamma_r(+0.0)
+	  returns positive infinity, in addition to lgamma_r(-0.0).
+	  AIX returns an incorrect result of negative infinity.
+
+	* math.c (ruby_lgamma_r): handle +0.0, in addition to -0.0.
+
 Thu Apr 28 01:11:14 2016  NARUSE, Yui  <naruse@r...>
 
 	* time.c: define _DEFAULT_SOURCE because glibc 2.20 depracates

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/