ruby-changes:42639
From: nagachika <ko1@a...>
Date: Fri, 22 Apr 2016 23:33:50 +0900 (JST)
Subject: [ruby-changes:42639] nagachika:r54713 (ruby_2_3): merge revision(s) 54144, 54699: [Backport #12139]
nagachika 2016-04-23 00:30:27 +0900 (Sat, 23 Apr 2016) New Revision: 54713 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=54713 Log: merge revision(s) 54144,54699: [Backport #12139] * lib/securerandom.rb (gen_random): to avoid blocking on Windows. On Windows OpenSSL RAND_bytes (underlying implementation is RAND_poll in crypto/rand/rand_win.c) may be blocked at NetStatisticsGet. https://wiki.openssl.org/index.php/Random_Numbers#Windows_Issues Instead of this, use Random.raw_seed directory (whose implementation CryptGenRandom is one of the source of entropy of RAND_poll on Windows). https://wiki.openssl.org/index.php/Random_Numbers Note: CryptGenRandom function is PRNG and doesn't check its entropy, so it won't block. [Bug #12139] https://msdn.microsoft.com/ja-jp/library/windows/desktop/aa379942.aspx https://tools.ietf.org/html/rfc4086#section-7.1.3 https://eprint.iacr.org/2007/419.pdf http://www.cs.huji.ac.il/~dolev/pubs/thesis/msc-thesis-leo.pdf Instead of this, use Random.raw_seed directly (whose implementation Modified directories: branches/ruby_2_3/ Modified files: branches/ruby_2_3/ChangeLog branches/ruby_2_3/lib/securerandom.rb branches/ruby_2_3/version.h Index: ruby_2_3/version.h =================================================================== --- ruby_2_3/version.h (revision 54712) +++ ruby_2_3/version.h (revision 54713) @@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_3/version.h#L1 #define RUBY_VERSION "2.3.0" #define RUBY_RELEASE_DATE "2016-04-23" -#define RUBY_PATCHLEVEL 102 +#define RUBY_PATCHLEVEL 103 #define RUBY_RELEASE_YEAR 2016 #define RUBY_RELEASE_MONTH 4 Index: ruby_2_3/lib/securerandom.rb =================================================================== --- ruby_2_3/lib/securerandom.rb (revision 54712) +++ ruby_2_3/lib/securerandom.rb (revision 54713) @@ -48,7 +48,7 @@ end https://github.com/ruby/ruby/blob/trunk/ruby_2_3/lib/securerandom.rb#L48 # module SecureRandom - if defined? OpenSSL::Random + if defined?(OpenSSL::Random) && /mswin|mingw/ !~ RUBY_PLATFORM def self.gen_random(n) @pid = 0 unless defined?(@pid) pid = $$ Index: ruby_2_3/ChangeLog =================================================================== --- ruby_2_3/ChangeLog (revision 54712) +++ ruby_2_3/ChangeLog (revision 54713) @@ -1,3 +1,21 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_3/ChangeLog#L1 +Sat Apr 23 00:29:15 2016 NARUSE, Yui <naruse@r...> + + * lib/securerandom.rb (gen_random): to avoid blocking on Windows. + On Windows OpenSSL RAND_bytes (underlying implementation is + RAND_poll in crypto/rand/rand_win.c) may be blocked at + NetStatisticsGet. + https://wiki.openssl.org/index.php/Random_Numbers#Windows_Issues + Instead of this, use Random.raw_seed directly (whose implementation + CryptGenRandom is one of the source of + entropy of RAND_poll on Windows). + https://wiki.openssl.org/index.php/Random_Numbers + Note: CryptGenRandom function is PRNG and doesn't check its entropy, + so it won't block. [Bug #12139] + https://msdn.microsoft.com/ja-jp/library/windows/desktop/aa379942.aspx + https://tools.ietf.org/html/rfc4086#section-7.1.3 + https://eprint.iacr.org/2007/419.pdf + http://www.cs.huji.ac.il/~dolev/pubs/thesis/msc-thesis-leo.pdf + Sat Apr 23 00:25:26 2016 Nobuyoshi Nakada <nobu@r...> * miniinit.c (Init_enc): add some common aliases of built-in Property changes on: ruby_2_3 ___________________________________________________________________ Modified: svn:mergeinfo Merged /trunk:r54144,54699 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/