ruby-changes:42607
From: nobu <ko1@a...>
Date: Fri, 22 Apr 2016 14:12:59 +0900 (JST)
Subject: [ruby-changes:42607] nobu:r54681 (trunk): eval_jump.c: restore previous error info
nobu 2016-04-22 15:09:29 +0900 (Fri, 22 Apr 2016) New Revision: 54681 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=54681 Log: eval_jump.c: restore previous error info * eval_jump.c (exec_end_procs_chain): restore previous error info for each end procs. [ruby-core:75038] [Bug #12302] Modified files: trunk/ChangeLog trunk/eval_jump.c trunk/test/ruby/test_beginendblock.rb Index: test/ruby/test_beginendblock.rb =================================================================== --- test/ruby/test_beginendblock.rb (revision 54680) +++ test/ruby/test_beginendblock.rb (revision 54681) @@ -130,4 +130,22 @@ at_exit { callcc {|_c| c = _c } } https://github.com/ruby/ruby/blob/trunk/test/ruby/test_beginendblock.rb#L130 EOS assert_normal_exit(script, bug9110) end + + def test_errinfo_at_exit + bug12302 = '[ruby-core:75038] [Bug #12302]' + assert_in_out_err([], <<-'end;', %w[2:exit 1:exit], [], bug12302) + at_exit do + puts "1:#{$!}" + end + + at_exit do + puts "2:#{$!}" + raise 'x' rescue nil + end + + at_exit do + exit + end + end; + end end Index: eval_jump.c =================================================================== --- eval_jump.c (revision 54680) +++ eval_jump.c (revision 54681) @@ -94,10 +94,11 @@ rb_mark_end_proc(void) https://github.com/ruby/ruby/blob/trunk/eval_jump.c#L94 } static void -exec_end_procs_chain(struct end_proc_data *volatile *procs) +exec_end_procs_chain(struct end_proc_data *volatile *procs, VALUE *errp) { struct end_proc_data volatile endproc; struct end_proc_data *link; + VALUE errinfo = *errp; while ((link = *procs) != 0) { *procs = link->next; @@ -105,6 +106,7 @@ exec_end_procs_chain(struct end_proc_dat https://github.com/ruby/ruby/blob/trunk/eval_jump.c#L106 xfree(link); rb_set_safe_level_force(endproc.safe); (*endproc.func) (endproc.data); + *errp = errinfo; } } @@ -119,8 +121,8 @@ rb_exec_end_proc(void) https://github.com/ruby/ruby/blob/trunk/eval_jump.c#L121 TH_PUSH_TAG(th); if ((status = EXEC_TAG()) == 0) { again: - exec_end_procs_chain(&ephemeral_end_procs); - exec_end_procs_chain(&end_procs); + exec_end_procs_chain(&ephemeral_end_procs, &th->errinfo); + exec_end_procs_chain(&end_procs, &th->errinfo); } else { VAR_INITIALIZED(th); Index: ChangeLog =================================================================== --- ChangeLog (revision 54680) +++ ChangeLog (revision 54681) @@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1 +Fri Apr 22 15:09:27 2016 Nobuyoshi Nakada <nobu@r...> + + * eval_jump.c (exec_end_procs_chain): restore previous error info + for each end procs. [ruby-core:75038] [Bug #12302] + Fri Apr 22 15:04:56 2016 NAKAMURA Usaku <usa@r...> * tool/redmine-backporter.rb: the fullpath of merger.rb is too long to -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/