naruse	2016-04-18 17:00:38 +0900 (Mon, 18 Apr 2016)

  New Revision: 54632

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=54632

  Log:
    merge revision(s) 54465: [Backport #12237]
    
    * thread.c (update_coverage): Do not track coverage in loaded files
      after Coverage.result. Avoids out-of-bounds access. [Bug #12237]
    
    * ext/coverage/coverage.c (coverage_clear_result_i): document.

  Modified directories:
    branches/ruby_2_3/
  Modified files:
    branches/ruby_2_3/ChangeLog
    branches/ruby_2_3/ext/coverage/coverage.c
    branches/ruby_2_3/thread.c
    branches/ruby_2_3/version.h
Index: ruby_2_3/version.h
===================================================================
--- ruby_2_3/version.h	(revision 54631)
+++ ruby_2_3/version.h	(revision 54632)
@@ -1,6 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_3/version.h#L1
 #define RUBY_VERSION "2.3.0"
 #define RUBY_RELEASE_DATE "2016-04-18"
-#define RUBY_PATCHLEVEL 87
+#define RUBY_PATCHLEVEL 88
 
 #define RUBY_RELEASE_YEAR 2016
 #define RUBY_RELEASE_MONTH 4
Index: ruby_2_3/ChangeLog
===================================================================
--- ruby_2_3/ChangeLog	(revision 54631)
+++ ruby_2_3/ChangeLog	(revision 54632)
@@ -1,3 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_3/ChangeLog#L1
+Mon Apr 18 16:56:31 2016  Benoit Daloze  <eregontp@g...>
+
+	* thread.c (update_coverage): Do not track coverage in loaded files
+	  after Coverage.result. Avoids out-of-bounds access. [Bug #12237]
+
+	* ext/coverage/coverage.c (coverage_clear_result_i): document.
+
 Mon Apr 18 16:33:50 2016  Nobuyoshi Nakada  <nobu@r...>
 
 	* ext/date/date_core.c (Init_date_core): [DOC] fix misplaced doc
Index: ruby_2_3/ext/coverage/coverage.c
===================================================================
--- ruby_2_3/ext/coverage/coverage.c	(revision 54631)
+++ ruby_2_3/ext/coverage/coverage.c	(revision 54632)
@@ -32,6 +32,7 @@ rb_coverage_start(VALUE klass) https://github.com/ruby/ruby/blob/trunk/ruby_2_3/ext/coverage/coverage.c#L32
     return Qnil;
 }
 
+/* Make coverage arrays empty so old covered files are no longer tracked. */
 static int
 coverage_clear_result_i(st_data_t key, st_data_t val, st_data_t h)
 {
Index: ruby_2_3/thread.c
===================================================================
--- ruby_2_3/thread.c	(revision 54631)
+++ ruby_2_3/thread.c	(revision 54632)
@@ -4768,7 +4768,7 @@ update_coverage(rb_event_flag_t event, V https://github.com/ruby/ruby/blob/trunk/ruby_2_3/thread.c#L4768
     if (coverage && RBASIC(coverage)->klass == 0) {
 	long line = rb_sourceline() - 1;
 	long count;
-	if (RARRAY_AREF(coverage, line) == Qnil) {
+	if (line >= RARRAY_LEN(coverage)) { /* no longer tracked */
 	    return;
 	}
 	count = FIX2LONG(RARRAY_AREF(coverage, line)) + 1;

Property changes on: ruby_2_3
___________________________________________________________________
Modified: svn:mergeinfo
   Merged /trunk:r54465


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/