ruby-changes:37910
From: nagachika <ko1@a...>
Date: Wed, 18 Mar 2015 00:56:10 +0900 (JST)
Subject: [ruby-changes:37910] nagachika:r49991 (ruby_2_1): merge revision(s) r49322: [Backport #10753]
nagachika 2015-03-18 00:55:50 +0900 (Wed, 18 Mar 2015) New Revision: 49991 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=49991 Log: merge revision(s) r49322: [Backport #10753] * vm_method.c (check_definition): Module#public_method_defined?, Module#private_method_defined?, Module#protected_method_defined? should not use refinements. [ruby-core:67656] [Bug #10753] Modified directories: branches/ruby_2_1/ Modified files: branches/ruby_2_1/ChangeLog branches/ruby_2_1/test/ruby/test_refinement.rb branches/ruby_2_1/version.h branches/ruby_2_1/vm_method.c Index: ruby_2_1/ChangeLog =================================================================== --- ruby_2_1/ChangeLog (revision 49990) +++ ruby_2_1/ChangeLog (revision 49991) @@ -1,3 +1,9 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_1/ChangeLog#L1 +Wed Mar 18 00:32:08 2015 Seiei Higa <hanachin@g...> + + * vm_method.c (check_definition): Module#public_method_defined?, + Module#private_method_defined?, Module#protected_method_defined? + should not use refinements. [ruby-core:67656] [Bug #10753] + Tue Mar 10 02:40:11 2015 SHIBATA Hiroshi <shibata.hiroshi@g...> * thread.c: Improve documentation for Thread#value Index: ruby_2_1/vm_method.c =================================================================== --- ruby_2_1/vm_method.c (revision 49990) +++ ruby_2_1/vm_method.c (revision 49991) @@ -1044,7 +1044,7 @@ check_definition(VALUE mod, VALUE mid, r https://github.com/ruby/ruby/blob/trunk/ruby_2_1/vm_method.c#L1044 const rb_method_entry_t *me; ID id = rb_check_id(&mid); if (!id) return Qfalse; - me = rb_method_entry(mod, id, 0); + me = rb_method_entry_without_refinements(mod, id, 0); if (me) { if (VISI_CHECK(me->flag, noex)) return Qtrue; Index: ruby_2_1/version.h =================================================================== --- ruby_2_1/version.h (revision 49990) +++ ruby_2_1/version.h (revision 49991) @@ -1,10 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ruby_2_1/version.h#L1 #define RUBY_VERSION "2.1.5" -#define RUBY_RELEASE_DATE "2015-03-10" -#define RUBY_PATCHLEVEL 312 +#define RUBY_RELEASE_DATE "2015-03-18" +#define RUBY_PATCHLEVEL 313 #define RUBY_RELEASE_YEAR 2015 #define RUBY_RELEASE_MONTH 3 -#define RUBY_RELEASE_DAY 10 +#define RUBY_RELEASE_DAY 18 #include "ruby/version.h" Index: ruby_2_1/test/ruby/test_refinement.rb =================================================================== --- ruby_2_1/test/ruby/test_refinement.rb (revision 49990) +++ ruby_2_1/test/ruby/test_refinement.rb (revision 49991) @@ -1206,6 +1206,81 @@ class TestRefinement < Test::Unit::TestC https://github.com/ruby/ruby/blob/trunk/ruby_2_1/test/ruby/test_refinement.rb#L1206 end; end + def test_refined_method_defined + assert_separately([], <<-"end;") + bug10753 = '[ruby-core:67656] [Bug #10753]' + + c = Class.new do + def refined_public; end + def refined_protected; end + def refined_private; end + + public :refined_public + protected :refined_protected + private :refined_private + end + + m = Module.new do + refine(c) do + def refined_public; end + def refined_protected; end + def refined_private; end + + public :refined_public + protected :refined_protected + private :refined_private + end + end + + using m + + assert_equal(true, c.public_method_defined?(:refined_public), bug10753) + assert_equal(false, c.public_method_defined?(:refined_protected), bug10753) + assert_equal(false, c.public_method_defined?(:refined_private), bug10753) + + assert_equal(false, c.protected_method_defined?(:refined_public), bug10753) + assert_equal(true, c.protected_method_defined?(:refined_protected), bug10753) + assert_equal(false, c.protected_method_defined?(:refined_private), bug10753) + + assert_equal(false, c.private_method_defined?(:refined_public), bug10753) + assert_equal(false, c.private_method_defined?(:refined_protected), bug10753) + assert_equal(true, c.private_method_defined?(:refined_private), bug10753) + end; + end + + def test_undefined_refined_method_defined + assert_separately([], <<-"end;") + bug10753 = '[ruby-core:67656] [Bug #10753]' + + c = Class.new + + m = Module.new do + refine(c) do + def undefined_refined_public; end + def undefined_refined_protected; end + def undefined_refined_private; end + public :undefined_refined_public + protected :undefined_refined_protected + private :undefined_refined_private + end + end + + using m + + assert_equal(false, c.public_method_defined?(:undefined_refined_public), bug10753) + assert_equal(false, c.public_method_defined?(:undefined_refined_protected), bug10753) + assert_equal(false, c.public_method_defined?(:undefined_refined_private), bug10753) + + assert_equal(false, c.protected_method_defined?(:undefined_refined_public), bug10753) + assert_equal(false, c.protected_method_defined?(:undefined_refined_protected), bug10753) + assert_equal(false, c.protected_method_defined?(:undefined_refined_private), bug10753) + + assert_equal(false, c.private_method_defined?(:undefined_refined_public), bug10753) + assert_equal(false, c.private_method_defined?(:undefined_refined_protected), bug10753) + assert_equal(false, c.private_method_defined?(:undefined_refined_private), bug10753) + end; + end + private def eval_using(mod, s) Property changes on: ruby_2_1 ___________________________________________________________________ Modified: svn:mergeinfo Merged /trunk:r49322 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/