ruby-changes:36741
From: nobu <ko1@a...>
Date: Sat, 13 Dec 2014 12:05:46 +0900 (JST)
Subject: [ruby-changes:36741] nobu:r48822 (trunk): revert r48819
nobu 2014-12-13 12:05:31 +0900 (Sat, 13 Dec 2014) New Revision: 48822 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=48822 Log: revert r48819 Modified files: trunk/test/openssl/test_ocsp.rb trunk/test/openssl/utils.rb Index: test/openssl/utils.rb =================================================================== --- test/openssl/utils.rb (revision 48821) +++ test/openssl/utils.rb (revision 48822) @@ -327,24 +327,4 @@ AQjjxMXhwULlmuR/K+WwlaZPiLIBYalLAZQ7ZbOP https://github.com/ruby/ruby/blob/trunk/test/openssl/utils.rb#L327 end end - module OpenSSL::OCSPTestSetup - def setup - ca_subj = OpenSSL::X509::Name.parse("/DC=org/DC=ruby-lang/CN=TestCA") - ca_key = OpenSSL::TestUtils::TEST_KEY_RSA1024 - ca_serial = 0xabcabcabcabc - - subj = OpenSSL::X509::Name.parse("/DC=org/DC=ruby-lang/CN=TestCert") - @key = OpenSSL::TestUtils::TEST_KEY_RSA1024 - serial = 0xabcabcabcabd - - now = Time.at(Time.now.to_i) # suppress usec - dgst = OpenSSL::Digest::SHA1.new - - @ca_cert = OpenSSL::TestUtils.issue_cert( - ca_subj, ca_key, ca_serial, now, now+3600, [], nil, nil, dgst) - @cert = OpenSSL::TestUtils.issue_cert( - subj, @key, serial, now, now+3600, [], @ca_cert, nil, dgst) - end - end - end if defined?(OpenSSL) Index: test/openssl/test_ocsp.rb =================================================================== --- test/openssl/test_ocsp.rb (revision 48821) +++ test/openssl/test_ocsp.rb (revision 48822) @@ -3,7 +3,23 @@ require_relative "utils" https://github.com/ruby/ruby/blob/trunk/test/openssl/test_ocsp.rb#L3 if defined?(OpenSSL) class OpenSSL::TestOCSP < Test::Unit::TestCase - include OpenSSL::OCSPTestSetup + def setup + ca_subj = OpenSSL::X509::Name.parse("/DC=org/DC=ruby-lang/CN=TestCA") + ca_key = OpenSSL::TestUtils::TEST_KEY_RSA1024 + ca_serial = 0xabcabcabcabc + + subj = OpenSSL::X509::Name.parse("/DC=org/DC=ruby-lang/CN=TestCert") + @key = OpenSSL::TestUtils::TEST_KEY_RSA1024 + serial = 0xabcabcabcabd + + now = Time.at(Time.now.to_i) # suppress usec + dgst = OpenSSL::Digest::SHA1.new + + @ca_cert = OpenSSL::TestUtils.issue_cert( + ca_subj, ca_key, ca_serial, now, now+3600, [], nil, nil, dgst) + @cert = OpenSSL::TestUtils.issue_cert( + subj, @key, serial, now, now+3600, [], @ca_cert, nil, dgst) + end def test_new_certificate_id cid = OpenSSL::OCSP::CertificateId.new(@cert, @ca_cert) @@ -18,9 +34,6 @@ class OpenSSL::TestOCSP < Test::Unit::Te https://github.com/ruby/ruby/blob/trunk/test/openssl/test_ocsp.rb#L34 end if defined?(OpenSSL::Digest::SHA256) def test_new_ocsp_request - assert_separately(%w[-ropenssl/utils -], <<-END) - extend OpenSSL::OCSPTestSetup - setup request = OpenSSL::OCSP::Request.new cid = OpenSSL::OCSP::CertificateId.new(@cert, @ca_cert, OpenSSL::Digest::SHA1.new) request.add_certid(cid) @@ -28,7 +41,6 @@ class OpenSSL::TestOCSP < Test::Unit::Te https://github.com/ruby/ruby/blob/trunk/test/openssl/test_ocsp.rb#L41 assert_kind_of OpenSSL::OCSP::Request, request # in current implementation not same instance of certificate id, but should contain same data assert_equal cid.serial, request.certid.first.serial - END end end -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/