[前][次][番号順一覧][スレッド一覧]

ruby-changes:34217

From: naruse <ko1@a...>
Date: Mon, 2 Jun 2014 09:36:40 +0900 (JST)
Subject: [ruby-changes:34217] naruse:r46279 (trunk): don't remove test results

naruse	2014-05-31 22:30:48 +0900 (Sat, 31 May 2014)

  New Revision: 46279

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?revision=46279&view=revision

  Log:
    don't remove test results
    
    r46180 removed dots but they express the result of tests: don't remove them.
    Moreover I don't understand why `read` is still used.
    
    http://u64.rubyci.org/~chkbuild/ruby-trunk/log/20140530T200301Z.fail.html.gz

  Modified files:
    trunk/test/lib/test/unit/parallel.rb
Index: test/lib/test/unit/parallel.rb
===================================================================
--- test/lib/test/unit/parallel.rb	(revision 46278)
+++ test/lib/test/unit/parallel.rb	(revision 46279)
@@ -35,9 +35,7 @@ module Test https://github.com/ruby/ruby/blob/trunk/test/lib/test/unit/parallel.rb#L35
 
         th = Thread.new do
           begin
-            while buf = (self.verbose ? i.gets : (i.readpartial(1024) || i.read(5)))
-              buf.force_encoding(Encoding::ASCII_8BIT)
-              buf.sub!(/\A\n?\.+(?!\z)/, '')
+            while buf = (self.verbose ? i.gets : i.readpartial(1024))
               _report "p", buf
             end
           rescue IOError

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]