nobu	2014-03-28 19:32:16 +0900 (Fri, 28 Mar 2014)

  New Revision: 45462

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=45462

  Log:
    struct.c: not_a_member message
    
    * struct.c (not_a_member): extract name error and use same error
      messages.  based on the patch by Marcus Stollsteimer <sto.mar AT
      web.de> at [ruby-core:61721].  [Bug #9684]

  Added directories:
    trunk/ext/-test-/struct/
    trunk/test/-ext-/struct/
  Added files:
    trunk/ext/-test-/struct/extconf.rb
    trunk/ext/-test-/struct/init.c
    trunk/ext/-test-/struct/member.c
    trunk/test/-ext-/struct/test_member.rb
  Modified files:
    trunk/ChangeLog
    trunk/struct.c
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 45461)
+++ ChangeLog	(revision 45462)
@@ -1,3 +1,9 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Fri Mar 28 19:32:13 2014  Nobuyoshi Nakada  <nobu@r...>
+
+	* struct.c (not_a_member): extract name error and use same error
+	  messages.  based on the patch by Marcus Stollsteimer <sto.mar AT
+	  web.de> at [ruby-core:61721].  [Bug #9684]
+
 Fri Mar 28 09:21:54 2014  SHIBATA Hiroshi  <shibata.hiroshi@g...>
 
 	* ext/psych/psych.gemspec: update gemspec for psych-2.0.5
Index: struct.c
===================================================================
--- struct.c	(revision 45461)
+++ struct.c	(revision 45462)
@@ -80,6 +80,13 @@ rb_struct_members_m(VALUE obj) https://github.com/ruby/ruby/blob/trunk/struct.c#L80
     return rb_struct_s_members_m(rb_obj_class(obj));
 }
 
+NORETURN(static void not_a_member(ID id));
+static void
+not_a_member(ID id)
+{
+    rb_name_error(id, "`%s' is not a struct member", rb_id2name(id));
+}
+
 VALUE
 rb_struct_getmember(VALUE obj, ID id)
 {
@@ -94,7 +101,7 @@ rb_struct_getmember(VALUE obj, ID id) https://github.com/ruby/ruby/blob/trunk/struct.c#L101
 	    return RSTRUCT_GET(obj, i);
 	}
     }
-    rb_name_error(id, "%s is not struct member", rb_id2name(id));
+    not_a_member(id);
 
     UNREACHABLE;
 }
@@ -143,19 +150,19 @@ rb_struct_set(VALUE obj, VALUE val) https://github.com/ruby/ruby/blob/trunk/struct.c#L150
 {
     VALUE members, slot;
     long i, len;
+    ID fid = rb_frame_this_func();
 
     members = rb_struct_members(obj);
     len = RARRAY_LEN(members);
     rb_struct_modify(obj);
     for (i=0; i<len; i++) {
 	slot = RARRAY_AREF(members, i);
-	if (rb_id_attrset(SYM2ID(slot)) == rb_frame_this_func()) {
+	if (rb_id_attrset(SYM2ID(slot)) == fid) {
 	    RSTRUCT_SET(obj, i, val);
 	    return val;
 	}
     }
-    rb_name_error(rb_frame_this_func(), "`%s' is not a struct member",
-		  rb_id2name(rb_frame_this_func()));
+    not_a_member(fid);
 
     UNREACHABLE;
 }
Index: ext/-test-/struct/init.c
===================================================================
--- ext/-test-/struct/init.c	(revision 0)
+++ ext/-test-/struct/init.c	(revision 45462)
@@ -0,0 +1,11 @@ https://github.com/ruby/ruby/blob/trunk/ext/-test-/struct/init.c#L1
+#include "ruby.h"
+
+#define init(n) {void Init_##n(VALUE klass); Init_##n(klass);}
+
+void
+Init_struct(void)
+{
+    VALUE mBug = rb_define_module("Bug");
+    VALUE klass = rb_define_class_under(mBug, "Struct", rb_cStruct);
+    TEST_INIT_FUNCS(init);
+}

Property changes on: ext/-test-/struct/init.c
___________________________________________________________________
Added: svn:eol-style
   + LF

Index: ext/-test-/struct/extconf.rb
===================================================================
--- ext/-test-/struct/extconf.rb	(revision 0)
+++ ext/-test-/struct/extconf.rb	(revision 45462)
@@ -0,0 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/ext/-test-/struct/extconf.rb#L1
+$INCFLAGS << " -I$(topdir) -I$(top_srcdir)"
+$srcs = Dir[File.join($srcdir, "*.{#{SRC_EXT.join(%q{,})}}")]
+inits = $srcs.map {|s| File.basename(s, ".*")}
+inits.delete("init")
+inits.map! {|s|"X(#{s})"}
+$defs << "-DTEST_INIT_FUNCS(X)=\"#{inits.join(' ')}\""
+create_makefile("-test-/struct")

Property changes on: ext/-test-/struct/extconf.rb
___________________________________________________________________
Added: svn:eol-style
   + LF

Index: ext/-test-/struct/member.c
===================================================================
--- ext/-test-/struct/member.c	(revision 0)
+++ ext/-test-/struct/member.c	(revision 45462)
@@ -0,0 +1,18 @@ https://github.com/ruby/ruby/blob/trunk/ext/-test-/struct/member.c#L1
+#include "ruby.h"
+
+static VALUE
+bug_struct_get(VALUE obj, VALUE name)
+{
+    ID id = rb_check_id(&name);
+
+    if (!id) {
+	rb_name_error_str(name, "`%"PRIsVALUE"' is not a struct member", name);
+    }
+    return rb_struct_getmember(obj, id);
+}
+
+void
+Init_member(VALUE klass)
+{
+    rb_define_method(klass, "get", bug_struct_get, 1);
+}

Property changes on: ext/-test-/struct/member.c
___________________________________________________________________
Added: svn:eol-style
   + LF

Index: test/-ext-/struct/test_member.rb
===================================================================
--- test/-ext-/struct/test_member.rb	(revision 0)
+++ test/-ext-/struct/test_member.rb	(revision 45462)
@@ -0,0 +1,12 @@ https://github.com/ruby/ruby/blob/trunk/test/-ext-/struct/test_member.rb#L1
+require 'test/unit'
+require "-test-/struct"
+
+class  Bug::Struct::Test_Member < Test::Unit::TestCase
+  S = Bug::Struct.new(:a)
+
+  def test_member_get
+    s = S.new(1)
+    assert_equal(1, s.get(:a))
+    assert_raise_with_message(NameError, /is not a struct member/) {s.get(:b)}
+  end
+end

Property changes on: test/-ext-/struct/test_member.rb
___________________________________________________________________
Added: svn:eol-style
   + LF


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/