[前][次][番号順一覧][スレッド一覧]

ruby-changes:32919

From: hsbt <ko1@a...>
Date: Sun, 16 Feb 2014 15:05:58 +0900 (JST)
Subject: [ruby-changes:32919] hsbt:r44998 (trunk): * test/net/ftp/test_ftp.rb: remove unused variables.

hsbt	2014-02-16 15:05:52 +0900 (Sun, 16 Feb 2014)

  New Revision: 44998

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=44998

  Log:
    * test/net/ftp/test_ftp.rb: remove unused variables.
      test/logger/test_logger.rb: ditto.

  Modified files:
    trunk/ChangeLog
    trunk/test/logger/test_logger.rb
    trunk/test/net/ftp/test_ftp.rb
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 44997)
+++ ChangeLog	(revision 44998)
@@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Sun Feb 16 15:00:28 2014  SHIBATA Hiroshi  <shibata.hiroshi@g...>
+
+	* test/net/ftp/test_ftp.rb: remove unused variables.
+	* test/logger/test_logger.rb: ditto.
+
 Sun Feb 16 14:52:46 2014  Eric Wong  <e@8...>
 
 	* dir.c (dir_s_glob): RB_GC_GUARD instead of volatile
Index: test/logger/test_logger.rb
===================================================================
--- test/logger/test_logger.rb	(revision 44997)
+++ test/logger/test_logger.rb	(revision 44998)
@@ -321,7 +321,7 @@ class TestLogDevice < Test::Unit::TestCa https://github.com/ruby/ruby/blob/trunk/test/logger/test_logger.rb#L321
     r, w = IO.pipe
     logdev = d(w)
     logdev.write("msg2\n\n")
-    read_ready, = IO.select([r], nil, nil, 0.1)
+    IO.select([r], nil, nil, 0.1)
     w.close
     msg = r.read
     r.close
@@ -347,7 +347,7 @@ class TestLogDevice < Test::Unit::TestCa https://github.com/ruby/ruby/blob/trunk/test/logger/test_logger.rb#L347
     r, w = IO.pipe
     logdev = d(w)
     logdev.write("msg2\n\n")
-    read_ready, = IO.select([r], nil, nil, 0.1)
+    IO.select([r], nil, nil, 0.1)
     assert(!w.closed?)
     logdev.close
     assert(w.closed?)
@@ -481,7 +481,6 @@ class TestLogDevice < Test::Unit::TestCa https://github.com/ruby/ruby/blob/trunk/test/logger/test_logger.rb#L481
     logfile0 = logfile + '.0'
     logfile1 = logfile + '.1'
     logfile2 = logfile + '.2'
-    logfile3 = logfile + '.3'
     tmpfile.close(true)
     File.unlink(logfile) if File.exist?(logfile)
     File.unlink(logfile0) if File.exist?(logfile0)
Index: test/net/ftp/test_ftp.rb
===================================================================
--- test/net/ftp/test_ftp.rb	(revision 44997)
+++ test/net/ftp/test_ftp.rb	(revision 44998)
@@ -428,11 +428,6 @@ class FTPTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L428
 
   def test_list_fail
     commands = []
-    list_lines = [
-      "-rw-r--r--    1 0        0               0 Mar 30 11:22 foo.txt",
-      "-rw-r--r--    1 0        0               0 Mar 30 11:22 bar.txt",
-      "-rw-r--r--    1 0        0               0 Mar 30 11:22 baz.txt"
-    ]
     server = create_ftp_server { |sock|
       sock.print("220 (test_ftp).\r\n")
       commands.push(sock.gets)
@@ -445,9 +440,6 @@ class FTPTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L440
       sock.print("200 Switching to ASCII mode.\r\n")
       line = sock.gets
       commands.push(line)
-      port_args = line.slice(/\APORT (.*)/, 1).split(/,/)
-      host = port_args[0, 4].join(".")
-      port = port_args[4, 2].map(&:to_i).inject {|x, y| (x << 8) + y}
       sock.print("200 PORT command successful.\r\n")
       commands.push(sock.gets)
       sock.print("553 Requested action not taken.\r\n")
@@ -589,7 +581,6 @@ class FTPTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L581
 
   def test_retrbinary_fail
     commands = []
-    binary_data = (0..0xff).map {|i| i.chr}.join * 4 * 3
     server = create_ftp_server { |sock|
       sock.print("220 (test_ftp).\r\n")
       commands.push(sock.gets)
@@ -600,9 +591,6 @@ class FTPTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L591
       sock.print("200 Switching to Binary mode.\r\n")
       line = sock.gets
       commands.push(line)
-      port_args = line.slice(/\APORT (.*)/, 1).split(/,/)
-      host = port_args[0, 4].join(".")
-      port = port_args[4, 2].map(&:to_i).inject {|x, y| (x << 8) + y}
       sock.print("200 PORT command successful.\r\n")
       commands.push(sock.gets)
       sock.print("550 Requested action not taken.\r\n")
@@ -678,7 +666,6 @@ class FTPTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L666
   def test_storbinary_fail
     commands = []
     binary_data = (0..0xff).map {|i| i.chr}.join * 4 * 3
-    stored_data = nil
     server = create_ftp_server { |sock|
       sock.print("220 (test_ftp).\r\n")
       commands.push(sock.gets)
@@ -689,9 +676,6 @@ class FTPTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/net/ftp/test_ftp.rb#L676
       sock.print("200 Switching to Binary mode.\r\n")
       line = sock.gets
       commands.push(line)
-      port_args = line.slice(/\APORT (.*)/, 1).split(/,/)
-      host = port_args[0, 4].join(".")
-      port = port_args[4, 2].map(&:to_i).inject {|x, y| (x << 8) + y}
       sock.print("200 PORT command successful.\r\n")
       commands.push(sock.gets)
       sock.print("452 Requested file action aborted.\r\n")

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]