[前][次][番号順一覧][スレッド一覧]

ruby-changes:31820

From: zzak <ko1@a...>
Date: Thu, 28 Nov 2013 21:16:06 +0900 (JST)
Subject: [ruby-changes:31820] zzak:r43899 (trunk): * doc/contributing.rdoc: [DOC] Add notes about deciding what to patch

zzak	2013-11-28 21:15:59 +0900 (Thu, 28 Nov 2013)

  New Revision: 43899

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=43899

  Log:
    * doc/contributing.rdoc: [DOC] Add notes about deciding what to patch

  Modified files:
    trunk/ChangeLog
    trunk/doc/contributing.rdoc
Index: doc/contributing.rdoc
===================================================================
--- doc/contributing.rdoc	(revision 43898)
+++ doc/contributing.rdoc	(revision 43899)
@@ -272,6 +272,24 @@ Manual}[https://bugs.ruby-lang.org/proje https://github.com/ruby/ruby/blob/trunk/doc/contributing.rdoc#L272
 
 == Contributing A Patch
 
+=== Deciding what to patch
+
+Before you submit a patch, there are a few things you should know:
+
+* Pay attention to the maintenance policy for stable and maintained versions of Ruby.
+* Released versions in security mode will not merge feature changes.
+* Search for previous discussions on ruby-core to verify the maintenance policy
+* Patches must be distributed under Ruby's license.
+* This license may change in the future, you must join the discussion if you don't agree to the change
+
+To improve the chance your patch will be accepted please follow these simple rules:
+
+* Bug fixes should be committed on trunk first
+* Format of the patch file must be a unified diff (ie: diff -pu, svn diff, or git diff)
+* Don't introduce cosmetic changes
+* Follow the original coding style of the code
+* Don't mix different changes in one commit
+
 First thing you should do is check out the code if you haven't already:
 
   git clone git://github.com/ruby/ruby.git ruby-trunk
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 43898)
+++ ChangeLog	(revision 43899)
@@ -1,3 +1,7 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Thu Nov 28 21:15:45 2013  Zachary Scott  <e@z...>
+
+	* doc/contributing.rdoc: [DOC] Add notes about deciding what to patch
+
 Thu Nov 28 19:43:45 2013  Masaki Matsushita  <glass.saga@g...>
 
 	* benchmark/bm_hash_flatten.rb: added. r43896 is about 4 times faster

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]