[前][次][番号順一覧][スレッド一覧]

ruby-changes:29009

From: eregon <ko1@a...>
Date: Tue, 4 Jun 2013 23:09:39 +0900 (JST)
Subject: [ruby-changes:29009] eregon:r41061 (trunk): * ext/objspace/objspace.c: improve wording and remove duplicated comment.

eregon	2013-06-04 23:09:25 +0900 (Tue, 04 Jun 2013)

  New Revision: 41061

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=41061

  Log:
    * ext/objspace/objspace.c: improve wording and remove duplicated comment.
      Based on a patch by Dave Goodchild. [Fixes GH-299]

  Modified files:
    trunk/ChangeLog
    trunk/ext/objspace/objspace.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 41060)
+++ ChangeLog	(revision 41061)
@@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Tue Jun  4 23:08:42 2013  Benoit Daloze  <eregontp@g...>
+
+	* ext/objspace/objspace.c: improve wording and remove duplicated comment.
+	  Based on a patch by Dave Goodchild. [Fixes GH-299]
+
 Tue Jun  4 18:41:47 2013  Tanaka Akira  <akr@f...>
 
 	* bignum.c (bitlength_bdigit): Fix an off-by-one error.
Index: ext/objspace/objspace.c
===================================================================
--- ext/objspace/objspace.c	(revision 41060)
+++ ext/objspace/objspace.c	(revision 41061)
@@ -12,17 +12,6 @@ https://github.com/ruby/ruby/blob/trunk/ext/objspace/objspace.c#L12
 
 **********************************************************************/
 
-/* objspace library extends ObjectSpace module and add several
- * methods to get internal statistic information about
- * object/memory management.
- *
- * Generally, you *SHOULD NOT*use this library if you do not know
- * about the MRI implementation.  Mainly, this library is for (memory)
- * profiler developers and MRI developers who need to know how MRI
- * memory usage.
- *
- */
-
 #include <ruby/ruby.h>
 #include <ruby/st.h>
 #include <ruby/io.h>
@@ -721,13 +710,13 @@ collect_values(st_data_t key, st_data_t https://github.com/ruby/ruby/blob/trunk/ext/objspace/objspace.c#L710
  *  [MRI specific feature] Return all reachable objects from `obj'.
  *
  *  This method returns all reachable objects from `obj'.
- *  If `obj' has references two or more references to same object `x',
- *  them returned array only include one `x' object.
- *  If `obj' is non-markable (non-heap management) object such as
- *  true, false, nil, symbols and Fixnums (and Flonum) them it simply
+ *  If `obj' has two or more references to the same object `x',
+ *  then returned array only includes one `x' object.
+ *  If `obj' is a non-markable (non-heap management) object such as
+ *  true, false, nil, symbols and Fixnums (and Flonum) then it simply
  *  returns nil.
  *
- *  If `obj' has references to internal object, then it returns
+ *  If `obj' has references to an internal object, then it returns
  *  instances of `ObjectSpace::InternalObjectWrapper' class.
  *  This object contains a reference to an internal object and
  *  you can check the type of internal object with `type' method.
@@ -738,7 +727,7 @@ collect_values(st_data_t key, st_data_t https://github.com/ruby/ruby/blob/trunk/ext/objspace/objspace.c#L727
  *
  *  With this method, you can find memory leaks.
  *
- *  This method is not expected to work except C Ruby.
+ *  This method is not expected to work except in C Ruby.
  *
  *  Example:
  *    ObjectSpace.reachable_objects_from(['a', 'b', 'c'])
@@ -782,13 +771,13 @@ reachable_objects_from(VALUE self, VALUE https://github.com/ruby/ruby/blob/trunk/ext/objspace/objspace.c#L771
 void Init_object_tracing(VALUE rb_mObjSpace);
 void Init_gc_hook(VALUE rb_mObjSpace);
 
-/* objspace library extends ObjectSpace module and add several
+/* The objspace library extends the ObjectSpace module and adds several
  * methods to get internal statistic information about
  * object/memory management.
  *
- * Generally, you *SHOULD NOT*use this library if you do not know
+ * Generally, you *SHOULD NOT* use this library if you do not know
  * about the MRI implementation.  Mainly, this library is for (memory)
- * profiler developers and MRI developers who need to know how MRI
+ * profiler developers and MRI developers who need to know about MRI
  * memory usage.
  */
 

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]