[前][次][番号順一覧][スレッド一覧]

ruby-changes:28368

From: duerst <ko1@a...>
Date: Tue, 23 Apr 2013 17:42:07 +0900 (JST)
Subject: [ruby-changes:28368] duerst:r40420 (trunk): lib/rexml/document.rb, lib/rexml/element.rb,

duerst	2013-04-23 17:41:56 +0900 (Tue, 23 Apr 2013)

  New Revision: 40420

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=40420

  Log:
    lib/rexml/document.rb, lib/rexml/element.rb,
    lib/rexml/formatters/pretty.rb: remove opinionated
    language in documentation. [Bug #8309],
    reported by Charles Beckmann

  Modified files:
    trunk/ChangeLog
    trunk/lib/rexml/document.rb
    trunk/lib/rexml/element.rb
    trunk/lib/rexml/formatters/pretty.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 40419)
+++ ChangeLog	(revision 40420)
@@ -1,3 +1,10 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1
+Tue Apr 23 17:40:40 2013  Martin Duerst <duerst@i...>
+
+	* lib/rexml/document.rb, lib/rexml/element.rb,
+	  lib/rexml/formatters/pretty.rb: remove opinionated
+	  language in documentation. [Bug #8309],
+	  reported by Charles Beckmann
+
 Tue Apr 23 14:04:44 2013  Shugo Maeda  <shugo@r...>
 
 	* lib/net/imap.rb (getacl_response): parse the mailbox of an ACL
Index: lib/rexml/document.rb
===================================================================
--- lib/rexml/document.rb	(revision 40419)
+++ lib/rexml/document.rb	(revision 40420)
@@ -195,11 +195,8 @@ module REXML https://github.com/ruby/ruby/blob/trunk/lib/rexml/document.rb#L195
     #   the absolute *value* of the document -- that is, it leaves the value
     #   and number of Text nodes in the document unchanged.
     # ie_hack::
-    #   Internet Explorer is the worst piece of crap to have ever been
-    #   written, with the possible exception of Windows itself.  Since IE is
-    #   unable to parse proper XML, we have to provide a hack to generate XML
-    #   that IE's limited abilities can handle.  This hack inserts a space
-    #   before the /> on empty tags.  Defaults to false
+    #   This hack inserts a space before the /> on empty tags to address
+    #   a limitation of Internet Explorer.  Defaults to false
     # encoding::
     #   Encoding name as String. Change output encoding to specified encoding
     #   instead of encoding in XML declaration.
Index: lib/rexml/element.rb
===================================================================
--- lib/rexml/element.rb	(revision 40419)
+++ lib/rexml/element.rb	(revision 40420)
@@ -678,11 +678,8 @@ module REXML https://github.com/ruby/ruby/blob/trunk/lib/rexml/element.rb#L678
     #   pretty-printed in such a way that the added whitespace does not affect
     #   the parse tree of the document
     # ie_hack::
-    #   Internet Explorer is the worst piece of crap to have ever been
-    #   written, with the possible exception of Windows itself.  Since IE is
-    #   unable to parse proper XML, we have to provide a hack to generate XML
-    #   that IE's limited abilities can handle.  This hack inserts a space
-    #   before the /> on empty tags.  Defaults to false
+    #   This hack inserts a space before the /> on empty tags to address
+    #   a limitation of Internet Explorer.  Defaults to false
     #
     #  out = ''
     #  doc.write( out )     #-> doc is written to the string 'out'
Index: lib/rexml/formatters/pretty.rb
===================================================================
--- lib/rexml/formatters/pretty.rb	(revision 40419)
+++ lib/rexml/formatters/pretty.rb	(revision 40420)
@@ -24,7 +24,7 @@ module REXML https://github.com/ruby/ruby/blob/trunk/lib/rexml/formatters/pretty.rb#L24
       #   is undefined.  Defaults to 2.
       # ie_hack::
       #   If true, the printer will insert whitespace before closing empty
-      #   tags, thereby allowing Internet Explorer's feeble XML parser to
+      #   tags, thereby allowing Internet Explorer's XML parser to
       #   function. Defaults to false.
       def initialize( indentation=2, ie_hack=false )
         @indentation = indentation

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]