ruby-changes:27575
From: nobu <ko1@a...>
Date: Thu, 7 Mar 2013 14:21:54 +0900 (JST)
Subject: [ruby-changes:27575] nobu:r39627 (trunk): compile.c: zsuper keyword args
nobu 2013-03-07 14:21:40 +0900 (Thu, 07 Mar 2013) New Revision: 39627 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=39627 Log: compile.c: zsuper keyword args * compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008] Modified files: trunk/ChangeLog trunk/compile.c trunk/test/ruby/test_super.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 39626) +++ ChangeLog (revision 39627) @@ -1,3 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/ChangeLog#L1 +Thu Mar 7 14:21:37 2013 Nobuyoshi Nakada <nobu@r...> + + * compile.c (iseq_compile_each): pass keyword arguments to zsuper, + with current values. [ruby-core:53114] [Bug #8008] + Thu Mar 7 12:53:47 2013 Eric Hodel <drbrain@s...> * lib/rubygems/commands/setup_command.rb: Install .pem files. Index: compile.c =================================================================== --- compile.c (revision 39626) +++ compile.c (revision 39627) @@ -4472,6 +4472,22 @@ iseq_compile_each(rb_iseq_t *iseq, LINK_ https://github.com/ruby/ruby/blob/trunk/compile.c#L4472 argc = post_len + post_start; } } + + if (liseq->arg_keyword > 0) { + int local_size = liseq->local_size; + int idx = local_size - liseq->arg_keyword; + argc++; + ADD_INSN1(args, line, putspecialobject, INT2FIX(VM_SPECIAL_OBJECT_VMCORE)); + ADD_INSN2(args, line, getlocal, INT2FIX(idx), INT2FIX(lvar_level)); + ADD_SEND (args, line, ID2SYM(rb_intern("dup")), INT2FIX(0)); + for (i = 0; i < liseq->arg_keywords; ++i) { + ID id = liseq->arg_keyword_table[i]; + idx = local_size - get_local_var_idx(liseq, id); + ADD_INSN1(args, line, putobject, ID2SYM(id)); + ADD_INSN2(args, line, getlocal, INT2FIX(idx), INT2FIX(lvar_level)); + } + ADD_SEND(args, line, ID2SYM(id_core_hash_merge_ptr), INT2FIX(i * 2 + 1)); + } } } Index: test/ruby/test_super.rb =================================================================== --- test/ruby/test_super.rb (revision 39626) +++ test/ruby/test_super.rb (revision 39627) @@ -7,6 +7,7 @@ class TestSuper < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_super.rb#L7 def double(a, b) [a,b] end def array(*a) a end def optional(a = 0) a end + def keyword(**a) a end end class Single1 < Base def single(*) super end @@ -50,6 +51,18 @@ class TestSuper < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_super.rb#L51 class Optional5 < Base def array(a = 1, b = 2, *) super end end + class Keyword1 < Base + def keyword(foo: "keyword1") super end + end + class Keyword2 < Base + def keyword(foo: "keyword2") + foo = "changed1" + x = super + foo = "changed2" + y = super + [x, y] + end + end def test_single1 assert_equal(1, Single1.new.single(1)) @@ -112,6 +125,14 @@ class TestSuper < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_super.rb#L125 assert_equal([9, 8], Optional5.new.array(9, 8)) assert_equal([9, 8, 7], Optional5.new.array(9, 8, 7)) end + def test_keyword1 + assert_equal({foo: "keyword1"}, Keyword1.new.keyword) + bug8008 = '[ruby-core:53114] [Bug #8008]' + assert_equal({foo: bug8008}, Keyword1.new.keyword(foo: bug8008)) + end + def test_keyword2 + assert_equal([{foo: "changed1"}, {foo: "changed2"}], Keyword2.new.keyword) + end class A def tt(aa) -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/